all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrea Corallo <acorallo@gnu.org>
To: kassick@gmail.com
Cc: 71654-done@debbugs.gnu.org
Subject: bug#71654: [PATCH] Fix display-buffer-override-next-command
Date: Wed, 19 Jun 2024 17:32:01 -0400	[thread overview]
Message-ID: <yp1wmmkfwku.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CAJvJD8hDy3H65jaG9rD5HCygovn_1j6MgiXDXQLOq4=103Sbhg@mail.gmail.com> (kassick@gmail.com's message of "Wed, 19 Jun 2024 12:20:19 -0300")

"kassick@gmail.com" <kassick@gmail.com> writes:

> When display-buffer-overriding-action's car is set to a function instead of a list, display-buffer-override-next-command
> must ensure that the car is a list before pushing a new element to it, otherwise the car will become a itself a cons-cell
> and the clear-fun will trigger a wrong-type-argumen error when trying to delq the action.
>
> The error can be triggered by using some minor mode that updates display-buffer-override-next-command (such as
> purpose-mode) and then calling other-window-prefix.

Hi Rodrigo,

the patch LGTM so I applied it after some indentation massage to master.

Closing then, happy to reopen if some more work is needed.

Thanks

  Andrea





  parent reply	other threads:[~2024-06-19 21:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 15:20 bug#71654: [PATCH] Fix display-buffer-override-next-command kassick
2024-06-19 21:17 ` Jeremy Bryant via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-19 21:53   ` kassick
2024-06-19 21:32 ` Andrea Corallo [this message]
2024-06-19 21:54   ` kassick
2024-06-19 22:11     ` Andrea Corallo
2024-06-19 22:16       ` kassick
2024-06-20  7:55         ` Andrea Corallo
2024-06-20  5:15       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yp1wmmkfwku.fsf@fencepost.gnu.org \
    --to=acorallo@gnu.org \
    --cc=71654-done@debbugs.gnu.org \
    --cc=kassick@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.