From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char Date: Sat, 17 Aug 2024 11:04:18 -0400 Message-ID: References: <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org> <20240817041648.A6687C2BC66@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33483"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Paul Eggert To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 17 17:05:01 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfKzE-0008VH-I4 for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Aug 2024 17:05:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfKyc-0006RQ-3k; Sat, 17 Aug 2024 11:04:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfKyZ-0006Qw-3H for emacs-devel@gnu.org; Sat, 17 Aug 2024 11:04:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfKyY-00006L-Id; Sat, 17 Aug 2024 11:04:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=clSvZvfB3Lm3HRg5gEacBepTQjKxLKpyJ5gXXPz7VTI=; b=hi7Q0HdxMVFScPpubaxG d21//Qa+G1n4LE3z1oZvcCGvOS0P8CxcBZBVewRGkbCWrVQOyIui3unDiGoo6o1DoeYhklhZI1RWa +F4bTranMQKo+Wo4YSyF+Nl/IBQM9SGFRNDg+5OGDMVIWvMDpDPlEAWf6sJOUTyZY1zeEwcdfzH5l nQmCdEukF6CruvpdljfvFscJCYs9hOvpi87NA3YbA5GJRBFH073CIdBuYQJhIfbffDxUTbGtZfzls z0WukbM6jqAEb133ydHQBtLpVWPzR03P7dNlukVLP955wMIKylAQTE9KJO59qZSqKPKpyBuZZCECH G0V+w4+osty7yw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sfKyY-0000px-88; Sat, 17 Aug 2024 11:04:18 -0400 In-Reply-To: <20240817041648.A6687C2BC66@vcs2.savannah.gnu.org> (Paul Eggert's message of "Sat, 17 Aug 2024 00:16:47 -0400 (EDT)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322859 Archived-At: Paul Eggert writes: > branch: master > commit 8c81818673ae9ff788c6e65fb90984f327b27964 > Author: Paul Eggert > Commit: Paul Eggert > > Tune volatile in read_char >=20=20=20=20=20 > * src/keyboard.c (read_char): Optimize access to a local volatile. Hi Paul, this change building with "--enable-checking=3Dall --enable-check-lisp-object-type" on my system (GCC 14 x86_64-pc-linux-gnu) is introducing: "keyboard.c:2520:15: warning: variable =E2=80=98c=E2=80=99 might be clobber= ed by =E2=80=98longjmp=E2=80=99 or =E2=80=98vfork=E2=80=99 [-Wclobbered]" Also wanted to ask, is this a performance optimization? Andrea