From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: MPS native subrs Date: Wed, 26 Jun 2024 10:41:23 -0400 Message-ID: References: <87v823xvq1.fsf@localhost> <87tthm3gq2.fsf@gmail.com> <87sex6ags5.fsf@localhost> <87msne3flr.fsf@gmail.com> <87frt63dvt.fsf@gmail.com> <86o77ulgk8.fsf@gnu.org> <87zfre1p3r.fsf@gmail.com> <87zfreo5u6.fsf@localhost> <87plsa1n8k.fsf@gmail.com> <87wmmio3vq.fsf@localhost> <87jzii1hbs.fsf_-_@gmail.com> <8734p61evv.fsf@gmail.com> <87iky0zvyz.fsf@gmail.com> <87ikxwamor.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7860"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , Helmut Eller , Eli Zaretskii To: Helmut Eller via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 26 16:41:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMTqF-0001sc-Ab for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Jun 2024 16:41:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMTpv-0003hm-1s; Wed, 26 Jun 2024 10:41:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMTpt-0003hV-6A for emacs-devel@gnu.org; Wed, 26 Jun 2024 10:41:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMTpr-0003Uw-O6; Wed, 26 Jun 2024 10:41:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/GiW/MMIMxYSRKq1x8D9RfXuAWwISRQSAKfFwRhyWVE=; b=c6XY+HstucdVy3fzLUbG u6qinwu9cjS0NUtUzwCWQ7jzf1wavJ2BnJSyB4UNRvKhEV54CBVt2fLwHuk9WE6dmdyP2iX5HMjT9 AerUrAl1nHJRv/Gfb5tLMGcvFeB96+ULSQw9BoMCDYeMaYH5R/YC8ry0ewbx18S1dMQcCqFp/1shJ /2ZUeglKeLFf/ikCCDnHrjArdMw7IA225I3pg76GCF4eE2oGCEenKF2twT3EZ4NjuNeVokQ7sEcUK CYaFpKUh+w7eA5nx+OL6Ohgp3LXalGDnaOLmzYbED9ZtQp4Aq/pzOzK5hjrCvtmtRU/7sjeCi/YKr yAsPjG9F5ereiQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sMTpr-00026n-85; Wed, 26 Jun 2024 10:41:23 -0400 In-Reply-To: <87ikxwamor.fsf_-_@gmail.com> (Helmut Eller via's message of "Tue, 25 Jun 2024 20:42:44 +0200") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320701 Archived-At: Helmut Eller via "Emacs development discussions." writes: > On Sat, Jun 22 2024, Helmut Eller wrote: >>>> I thought native comp works for you? >> >> I haven't tried with the latest dump loading code. I think that needs >> some work for native-comp-units. > > Here are some patches for this. I also have some questions: > > 1) In fix_subr, the &s->intspec.native field should only traced if the > subr is a non-primitive. Because, for primitives, it's a (possibly > non-aligned) char*. Right? I believe that's correct. > 2) In dump_subr, the command_modes field is dumped with dump_field_lv > for non-primitives but for primitives with dump_field_emacs_ptr. > Is this intentional or a bug? Right, I'm not the author of the change but I suspect as well it should be 'dump_field_lv'. > 3) In fix_subr, why is the command_modes field only traced if > HAVE_NATIVE_COMP? (Today was the first time I heard of the > command-modes function; still have no clue what it's used for :-) I think Gerd already replied. Andrea