From: Andrea Corallo <acorallo@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
Alan Mackenzie <acm@muc.de>, Eli Zaretskii <eliz@gnu.org>,
71934@debbugs.gnu.org
Subject: bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects)
Date: Mon, 08 Jul 2024 04:47:05 -0400 [thread overview]
Message-ID: <yp1v81gfeye.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvh6d062fk.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 07 Jul 2024 22:32:43 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> It's apparent that the one that used to work,
>>>
>>> (cl-defmethod comp--spill-lap-function ((form list))
>>>
>>> , no longer works since function forms were converted to a different
>>> format in March. It needs modifying to handle the new format.
>>
>> That was the question.
>>
>> So, of what kind can the argument FORM be? Any form (any lisp
>> expression - any kind of "code") - lambda lists, function values?
>>
>> As far as I understand the above method originally supported lambda
>> lists and you made it handle function values as well. And because
>> function values are now represented differently the above method does
>> not handle this case any more.
>>
>> Is this correct?
>
> Yeah, I also fail to understand the relationship between
> `comp--spill-lap-function` (which sounds internal to the compilation
> pipeline and thus might apply to all sorts of subexpressions of the
> input code) and `native-compile` (where adding support for function
> values affects only the "toplevel" of the input).
'comp--spill-lap-function' serves 'comp--spill-lap' which is the first
pass of the native compilation pipeline. So adding a new method there
is the usual way to make native-compile support new kind of inputs.
Andrea
next prev parent reply other threads:[~2024-07-08 8:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 5:11 bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 13:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 15:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 4:00 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 4:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 5:06 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 5:48 ` Eli Zaretskii
2024-07-05 8:46 ` Andrea Corallo
[not found] ` <jwvtth4c7f3.fsf-monnier+emacs@gnu.org>
[not found] ` <Zof2edaqLQfHD4_B@ACM>
[not found] ` <jwvbk3b970b.fsf-monnier+emacs@gnu.org>
2024-07-05 16:48 ` bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Alan Mackenzie
2024-07-05 18:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 19:55 ` Alan Mackenzie
2024-07-05 20:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 21:41 ` Alan Mackenzie
2024-07-06 1:06 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 6:36 ` Eli Zaretskii
2024-07-06 8:06 ` Andrea Corallo
2024-07-06 14:27 ` Alan Mackenzie
2024-07-08 1:35 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08 2:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08 8:47 ` Andrea Corallo [this message]
2024-07-08 10:18 ` Alan Mackenzie
2024-07-09 5:19 ` bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 7:48 ` bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Andrea Corallo
2024-07-06 11:01 ` Alan Mackenzie
2024-07-06 17:29 ` Andrea Corallo
2024-07-09 20:49 ` Andrea Corallo
2024-07-10 10:29 ` Alan Mackenzie
2024-07-10 11:28 ` Andrea Corallo
2024-07-06 7:33 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1v81gfeye.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=71934@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.