From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: emacs reproducible builds part1 of 2 : eln Date: Sun, 11 Feb 2024 05:24:10 -0500 Message-ID: References: <8d01d73e-7ce1-4b3a-a25c-03b518a7e584@lsmod.de> <83jzofj70t.fsf@gnu.org> <83edemiklb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20569"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , bernhardout@lsmod.de, emacs-devel@gnu.org, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , "Bernhard M. Wiedemann" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 11 11:25:10 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZ71K-000560-FK for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Feb 2024 11:25:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZ70R-0007eZ-M4; Sun, 11 Feb 2024 05:24:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ70P-0007eB-Iq for emacs-devel@gnu.org; Sun, 11 Feb 2024 05:24:13 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ70N-00011Z-05; Sun, 11 Feb 2024 05:24:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ARyZ+gZ3BN2urhh3dwqtNepnvo1TGsty3zTb2Oczw2k=; b=LDQInpHxW+U2exn8UpSM 9ZETA+VRRbJo/2ozO5OojHjdqTO9C4tkL0dfJ64/ayLS0MPgis5fp6j7+69WsadgeyeuCqRMql7p2 dM9JAIMKJ2Ew8cwKOxbMY36B+U8t65g4ASHbFd6cnBq0vcjRiAjp7s+2zco2gDySCz+ap4Q1IHWvw eE8E+lHvI83ljxUuXOvjfxZgY7jb28g1gazwuvqubfOUFSHfKkl8m8aLgFKEKQSVngEOl0rpCpbbl UZXYi4O8z99GlnOG95qj4o4QOKlZcrUmInpYPJRyvppmLLk+2koKpzCp9BdhKS9ELtussvhtYgrp3 xJtxYEOv8A2u6w==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rZ70M-0001sC-OJ; Sun, 11 Feb 2024 05:24:10 -0500 In-Reply-To: (Andrea Corallo's message of "Sat, 10 Feb 2024 15:37:38 -0500") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316110 Archived-At: Andrea Corallo writes: > Stefan Monnier writes: > >>>> So, I'm not sure it explains the phenomenon you're seeing (I haven't >>>> seen the rest of this thread yet). >>> >>> Interesting, I imagined the walk order is defined but my question is >>> what about two hash table with the same content but created in two >>> different sessions? >> >> Depends how they were filled: if they were filles by the same sequence >> of operations, then they should have the same walk-order. >> If not, then all bets are off. > > Okay that's good news, I'll investigate more tomorrow, the case is > pretty well defined now so should be possible to understand exactly what > is going on. Okay cool I pushed a fix in emacs29, with that installed we don't try to sort anymore conses based on their 'sxhash-equal' value because this is not stable over different Emacs sessions. With the change installed the build looks finally reproducible here. Bernhard please let us know if this solves the problem on your side as well. Thanks Andrea