From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. Date: Mon, 17 Jul 2023 09:42:31 -0400 Message-ID: References: <838rbhcxg0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7132"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 64642@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 15:43:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLOVV-0001fL-RL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 15:43:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLOVH-0003cw-Mi; Mon, 17 Jul 2023 09:43:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLOVC-0003b8-Bb for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 09:43:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLOVB-0000Sm-Ve for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 09:43:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLOVB-0005hp-RM for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 09:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 13:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64642 X-GNU-PR-Package: emacs Original-Received: via spool by 64642-submit@debbugs.gnu.org id=B64642.168960136021906 (code B ref 64642); Mon, 17 Jul 2023 13:43:01 +0000 Original-Received: (at 64642) by debbugs.gnu.org; 17 Jul 2023 13:42:40 +0000 Original-Received: from localhost ([127.0.0.1]:49524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLOUq-0005hG-14 for submit@debbugs.gnu.org; Mon, 17 Jul 2023 09:42:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLOUn-0005h0-RC for 64642@debbugs.gnu.org; Mon, 17 Jul 2023 09:42:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLOUi-0000MQ-1u; Mon, 17 Jul 2023 09:42:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=EDg5cc7VatxtCy3gAj2MsTW/EolelNmwVM0gmH/G3qs=; b=ZIMVH9an+/iYd5DoPx5W /6qo5EbjuAMq6KBoOR37XB+FrhbsZdyZ7sEuDSgV/WiU6wbW2rihPZbFyhlvL6Pyb+pMtMZ0S7+My cLt603Cdj20YH7HAo/cu1StpW0Jde14PB6fU946PRjYgvAHphXK/e36Lq5RmRFcODK8FYCMBRPluz Gl/BnzjtGfSSSOeeWecJW7At+JyV7rqCBoO4gE4E7btZxTw54ZDOKsTpeDksJ9hvqsP6iwxEwpt33 gDrVJRQgL7lTJ3FsiMVHcysIww9WrVLnAcFLiLfNNvQdyToksuFzX2uNR4l0+SjA2zw4kpSJzLQsJ MjEDCh6O9MI65Q==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qLOUh-0002QT-Dx; Mon, 17 Jul 2023 09:42:31 -0400 In-Reply-To: (Alan Mackenzie's message of "Sat, 15 Jul 2023 15:17:20 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265398 Archived-At: Alan Mackenzie writes: > Hello, Eli and Andrea. > > On Sat, Jul 15, 2023 at 12:53:51 +0300, Eli Zaretskii wrote: >> > Date: Sat, 15 Jul 2023 09:38:13 +0000 >> > From: Alan Mackenzie > >> > Hello, Emacs. > >> > In the Emacs 29 pretest version (or the master version): >> > (i) emacs -Q >> > (ii) C-x b foo.el >> > (iii) M-x emacs-lisp-mode >> > Don't set lexical-binding in this buffer. >> > (iv) Enter a function called foo: >> > (defun foo () "foo doc string" >> > (lambda (bar) "lambda doc string" (car bar))) >> > (v) With point after the function, evaluate it with C-x C-e. > >> > (vi) M-: (native-compile 'foo) >> > This signals an error, native-compiler-error-dyn-func. This is a bug. > >> > ######################################################################### > >> > The immediate cause of the bug is in the version of >> > comp-spill-lap-function which processes named functions (comp.el). >> > Unlike the other version of the cl-defmethod (which processes lambda >> > functions), there is no code for dynamic functions here. > >> > If the intention is not to process dynamic functions, this should be >> > indicated by an error message rather than a signal. Personally, I feel >> > that dynamic functions ought to be handled in Emacs-29. > >> > Fixing this bug should be relatively straightforward, since it should >> > only involve copying and adapting the corresponding code in the lambda >> > version of comp-spill-lap-function. > >> Adding Andrea. > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is >> so simple that will surprise me. > > Here is a fix. Its simplicity probably doesn't surprise you (Eli), but > the change is entirely within one function, and a lot of the patch is > just whitespace changes. > > There are no problems running make bootstrap or make check with patch in > place. It also solves the bug; unless there are good reasons dynamically > bound functions weren't handled. Andrea? Hi Alan, the fix LGTM thanks for the patch, I think we only need to add a test as well to exercise this code, something like the "free-fun" test in comp-tests.el. Thanks Andrea