From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#72228: 31.0.50; Wrong number fontification in cmake-ts-mode Date: Wed, 07 Aug 2024 04:45:51 -0400 Message-ID: References: <875xszm205.fsf.ref@aol.com> <875xszm205.fsf@aol.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34892"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Ergus , 72228@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 07 10:49:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbcLu-0008wG-Df for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Aug 2024 10:49:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbcLY-0001du-4E; Wed, 07 Aug 2024 04:48:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbcLW-0001dj-UP for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 04:48:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbcLW-0002NQ-Jq for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 04:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=eWYTzaVE3vpABfubSDOAKxyULxoBkfZFKXy0dca5Sw4=; b=a8/iffVwn2NXTJa1ojqBRTh3y5bgfC2Jcv/hDPgcb6LL9FBukNLzru4ysR0Al8ArQHCEw9lgBcmbyuEdKj74fuyUoZ8AMUwRv9XdAa5VT4Q2Kq/5pmio4ysqjzaAhNpXmXBcTYblpbN1YFfEsHblajtCPVVdEnd+kyaEOY7H0Zl31lu7Hgi6Q56DMqoJNH56MrXy/4zWJQO4UJMrNmwC7qMPB7eDdXrSjZWLVcT26WEE9XJacFgaEhL5wBIQJp9afFUQ7xBEyDhWESq23kcUJ4DwJMa//v9KeIajlallaPTtSZ2wi9ZrJHRcSEhqS/N5GczhZ3Q2K+HG6/bzXNhopA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbcLu-0005Vo-IL for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2024 04:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2024 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72228 X-GNU-PR-Package: emacs Original-Received: via spool by 72228-submit@debbugs.gnu.org id=B72228.172302051721148 (code B ref 72228); Wed, 07 Aug 2024 08:49:02 +0000 Original-Received: (at 72228) by debbugs.gnu.org; 7 Aug 2024 08:48:37 +0000 Original-Received: from localhost ([127.0.0.1]:33630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbcLV-0005V2-6S for submit@debbugs.gnu.org; Wed, 07 Aug 2024 04:48:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbcLS-0005Uk-HA for 72228@debbugs.gnu.org; Wed, 07 Aug 2024 04:48:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbcIr-00024k-DJ; Wed, 07 Aug 2024 04:45:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=eWYTzaVE3vpABfubSDOAKxyULxoBkfZFKXy0dca5Sw4=; b=jVjdY+aXr2hf8gf54f9F bUZ0yPgdQ5jr2riVB8Lzp5gJvjztjVtN179bTkuA9/c+SMowElmukSzk77R9Duy2e8+YMR5YpqExf HS3QiBSY239+AR9q6/LiAMf9BAbAQQVkpuV1Afhi4LiIf0c/8Wc0sY5/CsRnMmW0r667rF1v/34wJ yWp2ZPoM5ky5qYHDxfv3RHGDBjH1YAzkZtZJcd0ZdyZYtrp6ewcp0LgH9cBsfsZSvCzAkp2bQdpjY 1bphYZ2OdOKnM8xjWbvnga1pWgci7RpJHzhEobfD7K0U8bGK5sC2yQ0CCBs5G4wiGubYNqgKKOzSQ h+51BpJOF1mKdw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sbcIp-0004e0-5R; Wed, 07 Aug 2024 04:45:53 -0400 In-Reply-To: (Randy Taylor's message of "Wed, 07 Aug 2024 01:00:01 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289868 Archived-At: Randy Taylor writes: > On Monday, July 22nd, 2024 at 22:32, Randy Taylor wrote: >> >> >> On Sunday, July 21st, 2024 at 07:13, Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs@gnu.org wrote: >> >> > When using cmake-ts-mode the numbers have 3 different faces: >> > >> > 1, 2, 100: font-lock-number-face (OK) >> > >> > 0 : font-lock-constant-face. The cmake-ts-mode--constants takes >> > precedence over regex in font-lock-number-face. It is not clear that >> > this one can be fixed. >> >> >> 1 also gets font-lock-constant-face. >> >> I think we should just remove "1" and "0" from cmake-ts-mode--constants. >> >> > -1, -2 : Not fontified. This seems simpler to fix, the regex in >> > font-lock-number-face is missing a `-?' before the first [[:digit:]]) >> >> >> Indeed. Would you like to submit a patch for that and the above? > > I haven't heard anything back, so I've attached a patch doing so. Hi Randy, I've installed your change. One comment: I'd suggest we start adding some tests for the mode in "test/lisp/progmodes", this would help catching future potential regressions. Ergus or Randy feel free to close if you think we are done with this bug. Thanks Andrea