From: Andrea Corallo <acorallo@gnu.org>
To: Randy Taylor <dev@rjt.dev>
Cc: Ergus <spacibba@aol.com>, 72228@debbugs.gnu.org
Subject: bug#72228: 31.0.50; Wrong number fontification in cmake-ts-mode
Date: Wed, 07 Aug 2024 04:45:51 -0400 [thread overview]
Message-ID: <yp1le18k9fk.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <lUk3ntEQPvJrFemqfMn3pw1fDNz3OkeI0wnEd4NiaBmTXfH3kDPBxe73F8bM31L6saZfVF1H2zbKd5UriA68lVumEtr-C3Wi7quPx3aSLaM=@rjt.dev> (Randy Taylor's message of "Wed, 07 Aug 2024 01:00:01 +0000")
Randy Taylor <dev@rjt.dev> writes:
> On Monday, July 22nd, 2024 at 22:32, Randy Taylor <dev@rjt.dev> wrote:
>>
>>
>> On Sunday, July 21st, 2024 at 07:13, Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" bug-gnu-emacs@gnu.org wrote:
>>
>> > When using cmake-ts-mode the numbers have 3 different faces:
>> >
>> > 1, 2, 100: font-lock-number-face (OK)
>> >
>> > 0 : font-lock-constant-face. The cmake-ts-mode--constants takes
>> > precedence over regex in font-lock-number-face. It is not clear that
>> > this one can be fixed.
>>
>>
>> 1 also gets font-lock-constant-face.
>>
>> I think we should just remove "1" and "0" from cmake-ts-mode--constants.
>>
>> > -1, -2 : Not fontified. This seems simpler to fix, the regex in
>> > font-lock-number-face is missing a `-?' before the first [[:digit:]])
>>
>>
>> Indeed. Would you like to submit a patch for that and the above?
>
> I haven't heard anything back, so I've attached a patch doing so.
Hi Randy,
I've installed your change.
One comment: I'd suggest we start adding some tests for the mode in
"test/lisp/progmodes", this would help catching future potential
regressions.
Ergus or Randy feel free to close if you think we are done with this
bug.
Thanks
Andrea
next prev parent reply other threads:[~2024-08-07 8:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <875xszm205.fsf.ref@aol.com>
2024-07-21 11:13 ` bug#72228: 31.0.50; Wrong number fontification in cmake-ts-mode Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-22 2:25 ` Randy Taylor
2024-07-23 2:32 ` Randy Taylor
2024-08-07 1:00 ` Randy Taylor
2024-08-07 8:45 ` Andrea Corallo [this message]
2024-08-07 13:14 ` Randy Taylor
2024-08-07 14:02 ` Andrea Corallo
2024-08-07 14:57 ` Randy Taylor
2024-08-07 15:38 ` Andrea Corallo
2024-08-07 15:52 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1le18k9fk.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=72228@debbugs.gnu.org \
--cc=dev@rjt.dev \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.