From: Andrea Corallo <acorallo@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions
Date: Wed, 06 Mar 2024 14:06:57 -0500 [thread overview]
Message-ID: <yp1jzmfuqlq.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvy1avmgvc.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 06 Mar 2024 12:09:56 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Okay I pushed the changes to render all preloaded types.
>
> Thanks.
>
> It needs a bit more work, I think: `ppss` is marked as being a subtype
> of `atom` but it's a subtype of `list`. That probably affects all the
> defstructs declared with (:type list), and arguably for those declared
> with (:type array) the supertype should be `array` rather than `atom`.
> [ One could also argue that they shouldn't be in there at all because we
> can't actually recognize those objects as being of that type, but
> maybe it's OK to keep them. ]
Yes I believe this affects the compiler as well. I'd like to fix it, I
just have to find some time to read some cl- code to understand how to
distinguish them, the patch should be easy.
Thanks
Andrea
next prev parent reply other threads:[~2024-03-06 19:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org>
[not found] ` <20240303230900.3A353C12C5E@vcs2.savannah.gnu.org>
2024-03-04 2:11 ` master 99483e214fd 2/3: Set org-macro-templates more lazily Po Lu
2024-03-04 3:11 ` Stefan Monnier
[not found] ` <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org>
2024-03-04 9:36 ` master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Andrea Corallo
2024-03-04 9:46 ` Andrea Corallo
2024-03-04 15:55 ` Stefan Monnier
2024-03-04 16:19 ` Andrea Corallo
2024-03-05 0:08 ` Stefan Monnier
2024-03-05 9:34 ` Andrea Corallo
2024-03-05 14:35 ` Andrea Corallo
2024-03-05 15:30 ` Stefan Monnier
2024-03-05 17:25 ` Andrea Corallo
2024-03-05 18:06 ` Stefan Monnier
2024-03-06 12:34 ` Andrea Corallo
2024-03-06 16:19 ` Andrea Corallo
2024-03-06 17:09 ` Stefan Monnier
2024-03-06 19:06 ` Andrea Corallo [this message]
2024-03-06 21:49 ` Stefan Monnier
2024-03-07 3:37 ` Stefan Monnier
2024-03-07 8:03 ` Andrea Corallo
2024-03-08 7:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1jzmfuqlq.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.