From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps Date: Mon, 21 Oct 2024 04:00:42 -0400 Message-ID: References: <172948055644.3805440.7086621144248259008@vcs3.savannah.gnu.org> <20241021031557.6BAE930F2F1@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26395"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 21 10:01:45 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t2nMG-0006Vj-Sk for ged-emacs-devel@m.gmane-mx.org; Mon, 21 Oct 2024 10:01:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t2nLV-0000fG-RN; Mon, 21 Oct 2024 04:00:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2nLI-0000bZ-6m for emacs-devel@gnu.org; Mon, 21 Oct 2024 04:00:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t2nLH-0000wn-TV; Mon, 21 Oct 2024 04:00:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=iL+PuhH+k8uzWQO1e7oMuqY8xYQOqm/RxVLosl5UJTw=; b=X3VMOeA2KLBAeczKzypC xY75qL8urgoGSZNqkWTtofhk1S5/HC/3Sqt6Z2FhfGVQJ4MXdhwbCxvinfrCD2Q16AqL6p1+hw60X qz4t+vRylKHP+9SIG++P07dzEb4B1d0cEir3e16cvDdq/POj5KHix9pjYsZdTzWcwqzpJZcpmITqo E35c9JOD2JhM2JTfvT1Sy4980pD+xgWC5CzV2zbkeI2sKfGUhPfpUWU/8NV4Vlo8qmSA/Tv5AVxPt An7KTMwB0ToYVgepe7BRznvsl3mY2zdWGyB6WwRaqXv+rvM8FC9zdIcz3oX+9EdT1NgOPQbX/WPq2 8Q1fl4dqEzLNaw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1t2nLH-0001Nz-3t; Mon, 21 Oct 2024 04:00:43 -0400 In-Reply-To: <20241021031557.6BAE930F2F1@vcs3.savannah.gnu.org> (Jim Porter's message of "Sun, 20 Oct 2024 23:15:57 -0400 (EDT)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324700 Archived-At: Jim Porter writes: > branch: master > commit b573aaab76b55ec276b9190570b3ca3ae72cb416 > Author: Jim Porter > Commit: Jim Porter > > ; Make utility functions for getting the Eshell non-special regexps >=20=20=20=20=20 > * lisp/eshell/esh-arg.el (eshell-inside-quote-regexp) > (eshell-outside-quote-regexp): Rename to... > (eshell--non-special-inside-quote-regexp) > (eshell--non-special-outside-quote-regexp): ... these, and add > defsubsts. > (eshell-arg-initialize): Don't initialize regexp variables. > (eshell-parse-non-special): ... use them. >=20=20=20=20=20 > * lisp/eshell/em-glob.el (eshell-glob-chars-regexp): Use 'rx-to-strin= g'. Hi Jim, If I'm not wrong this commit once merged into master is causing the following warnings: eshell/em-script.el:75:9: Warning: Unused lexical variable =E2=80=98eshell-outside-quote-regexp=E2=80=99 eshell/em-script.el:74:9: Warning: Unused lexical variable =E2=80=98eshell-inside-quote-regexp=E2=80=99 Would you ming having a look? Thanks! Andrea