From: Andrea Corallo <acorallo@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
acm@muc.de, monnier@iro.umontreal.ca, 71934@debbugs.gnu.org
Subject: bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects)
Date: Sat, 06 Jul 2024 04:06:25 -0400 [thread overview]
Message-ID: <yp1h6d3gd1a.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <86plrr58nv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jul 2024 09:36:20 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Michael Heerdegen <michael_heerdegen@web.de>
>> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, Andrea Corallo
>> <acorallo@gnu.org>, Eli Zaretskii <eliz@gnu.org>, 71934@debbugs.gnu.org
>> Date: Sat, 06 Jul 2024 03:06:24 +0200
>>
>> Alan Mackenzie <acm@muc.de> writes:
>>
>> > > > All very clever arguments, no doubt, but in the end it means you
>> > > > cannot native compile foo.
>> >
>> > > To obey the docstring, ....
>> >
>> > Forget that doc string, just do what is right, expected, and convenient
>> > for Emacs users, and adjust the doc string afterwards.
>>
>> We are actually trying to do that, but we don't understand the code
>> because of the lacking or wrong documentation.
>
> I don't understand this difficulty. Andrea, who wrote that function
> (and everything around it) is here, and is very helpful. How come
> this lack of understanding, let alone lack of documentation, is still
> with us?
Must say I'm really lost in this thread.
First I don't understand the functionality that got lost.
Second the method "comp-spill-lap-function ((form list))" never served the
case (native-compile 'foo) but rather (native-compile '(lambda () 3)).
(Now if the form (closure () 3) does not exist in elisp as valid form
this might translate in 1 line fix in 'comp-spill-lap-function ((form
list))' but let discuss this aside and is not about a lost
functionality).
(native-compile 'foo) is served by 'comp--spill-lap-function ((function-name symbol))'.
Also:
(native-compile 'foo) works (as always did) and even what Alan added
(native compiling lambdas in function native compiled by symbol name)
that is:
(defun foo () "foo doc string"
(lambda () "lambda doc string" 3))
(subr-native-elisp-p (funcall (native-compile 'foo)))
Still works for me on master.
So I must be really missing something in this discussion.
Let us please stick to exactly what worked in which version and what
does not in which other version, if we identify a case will be easy to
fix.
And even more importantly, I'll make sure we have a test that covers
that case so we can't have any other regression (assuming we had one).
Thanks
Andrea
next prev parent reply other threads:[~2024-07-06 8:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 5:11 bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 13:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-04 15:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 4:00 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 4:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 5:06 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 5:48 ` Eli Zaretskii
2024-07-05 8:46 ` Andrea Corallo
[not found] ` <jwvtth4c7f3.fsf-monnier+emacs@gnu.org>
[not found] ` <Zof2edaqLQfHD4_B@ACM>
[not found] ` <jwvbk3b970b.fsf-monnier+emacs@gnu.org>
2024-07-05 16:48 ` bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Alan Mackenzie
2024-07-05 18:17 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 19:55 ` Alan Mackenzie
2024-07-05 20:26 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-05 21:41 ` Alan Mackenzie
2024-07-06 1:06 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 6:36 ` Eli Zaretskii
2024-07-06 8:06 ` Andrea Corallo [this message]
2024-07-06 14:27 ` Alan Mackenzie
2024-07-08 1:35 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08 2:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08 8:47 ` Andrea Corallo
2024-07-08 10:18 ` Alan Mackenzie
2024-07-09 5:19 ` bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-06 7:48 ` bug#71934: comp--spill-lap-function and closure (wad: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects) Andrea Corallo
2024-07-06 11:01 ` Alan Mackenzie
2024-07-06 17:29 ` Andrea Corallo
2024-07-09 20:49 ` Andrea Corallo
2024-07-10 10:29 ` Alan Mackenzie
2024-07-10 11:28 ` Andrea Corallo
2024-07-06 7:33 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1h6d3gd1a.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=71934@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.