From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Introducing 'safety' compilation parameter Date: Mon, 13 May 2024 17:12:15 -0400 Message-ID: References: <864jb1y1uu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , emacs-devel@gnu.org, mattias.engdegard@gmail.com, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 13 23:12:52 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6cya-0005da-Jd for ged-emacs-devel@m.gmane-mx.org; Mon, 13 May 2024 23:12:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6cy3-0004uL-8Z; Mon, 13 May 2024 17:12:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6cy1-0004u1-Od for emacs-devel@gnu.org; Mon, 13 May 2024 17:12:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6cy1-0004e7-FG; Mon, 13 May 2024 17:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=uOnNNMisk9dE9VIZdoVlxuejoN8urKJ6rkf4LDS9KJ4=; b=q8hmb0bw1Dq4zflAF8xC 7CqsThEM83EWZJocCQfepo7HRiGGWZMHWfXtYc/qsj3AVhgx/BqSQ/m8PD/TAH0H8w6LU/XwqFvqk x0uF1YQJjF9KJgMWHZysEEz7hR6BgB/h68YW5IzxjDHiu4xw/zXWxGCK4nCW5p89HPtMT3nZD3Fbm QJ6NDSSQt4TstLlAH1tX8wgFYSyR+Sk7Wajzexg7MhIC/xvIn6HWlJtNos5omF0rtDjw1fvMS7RWy 29VAat6tgEwZvy0qiIptaHHkTsg6qAaaLjlBCyYVszdfCjSkZgoO9Tx7PSokdw3tBKPXwmOBlSzyj uRDnC+v+7m9DwQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1s6cy0-0006oi-9C; Mon, 13 May 2024 17:12:16 -0400 In-Reply-To: <864jb1y1uu.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 13 May 2024 21:59:37 +0300") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319208 Archived-At: Eli Zaretskii writes: >> From: Stefan Monnier >> Cc: emacs-devel@gnu.org, Eli Zaretskii , >> mattias.engdegard@gmail.com, stefankangas@gmail.com >> Date: Sun, 12 May 2024 22:29:08 -0400 >>=20 >> > Okay I pushed scratch/comp-safety2 changing the knob name to >> > 'compilation-safety' and gating the dangerous optimizations as >> > discussed. >>=20 >> Thanks. LGTM now (I'm still not sure we need both "safety" and "speed" >> controls, but we may as well follow CL's lead). > > Agreed. Andrea, feel free to land this on master, and thanks. Done now. As usual feel free to round any edge if you spot it =F0=9F=99=8F Thanks Andrea