From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/elisp-benchmarks fccb7bbaad 1/2: * Handle 'compilation-safety' Date: Wed, 15 May 2024 14:41:20 -0400 Message-ID: References: <171579536498.3206.16174588953622583400@vcs2.savannah.gnu.org> <20240515174925.A0BEFC2BC82@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32442"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Andrea Corallo , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 15 20:42:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7Ja8-0008GG-IK for ged-emacs-devel@m.gmane-mx.org; Wed, 15 May 2024 20:42:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7JZD-000203-M7; Wed, 15 May 2024 14:41:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7JZ8-0001zd-FV for emacs-devel@gnu.org; Wed, 15 May 2024 14:41:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7JZ8-0008OP-0R; Wed, 15 May 2024 14:41:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=rgmgc6ADXaUhdjNNcvmKT6tR2t7OxjlGHBuU71NJ5mU=; b=QpmlTAHuf75A+l0SMNPj TMa0RjeEXAk8QSSLwNH770/3xADbnvP4CBTU+Op5REl2+zAL2frT2Oc7jZenUUf0GaZV683VoekTA Vi6ozfYp+hv/IngGfLIu1n8kttao0FpmbpjfTGpYH9PwoOx/FYuqfyVJ3PRQKhhbS+V8IRDel1or7 0j+PwfUTNS1uRvOLmFkr0plFA88PEfKgFQxJ5wiLEq9vuY9n05eVatsrW0KS6HorjzZfsjb0WsJ6v ir9DgWn/25D+GFrLcb2OMEDZz4E5B1egSxO27DOLKwQ6Dg5HaXI3vKYrIFomGUENnZR4wSuiI1snU Buq3vUCFHdUGug==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1s7JZ2-0007Xz-H2; Wed, 15 May 2024 14:41:24 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 15 May 2024 14:03:01 -0400") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319266 Archived-At: Stefan Monnier writes: >> +(unless (boundp 'compilation-safety) >> + (defvar compilation-safety)) > > That makes no sense: (defvar compilation-safety) has no runtime effect, > it does not define the variable, it just tells the compiler that the > variable exists elsewhere and is dynamically scoped. Yes that was my intent, but I've got my test wrong and was sidetracked. Anyway does 0eb498f77b looks better? Thanks Andrea