From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Flickering tests Date: Tue, 09 Jul 2024 04:39:33 -0400 Message-ID: References: <87ed8bhnrb.fsf@gmx.de> <8734oqh4d2.fsf@gmx.de> <87bk3c70jj.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15888"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 10:40:40 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sR6Ot-0003yR-RE for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 10:40:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sR6O2-00076o-3N; Tue, 09 Jul 2024 04:39:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR6Nt-00075e-6w for emacs-devel@gnu.org; Tue, 09 Jul 2024 04:39:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sR6Nr-0001Uo-Me; Tue, 09 Jul 2024 04:39:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=5xDxVWDplkk7jZOnBqhoR0FBPhasTQMykNuW5ouQ7yY=; b=rdBhwQxb5jiNIlcWdHTb M44DhoH8RwD7og0j4Yaz4iOUZTGSkhSiG3x0YREm0h3Apw8V0JMD9P3DExMy5rjRrChiOSkYg6j8Z p8lwjcbZFKzdn/udHkPe1nKaH5eQ9NuFrEWcd7VO65c19mr2PBUGVxm0gL4K4NWCtwntVobmsw/wq Uq5+R4jEzPc1bSR9Z/w7aKnI6Ot7QyC79a30kgRw3lzYuIVaogC+dwzHws+l2crAG65wvWVG0f97n wcBFtJDdnPjMDOzkeRbv2bbHYZLumzKX/AlQChYKrOQaEG/0k5necSlY4ug9HNNoh6GiJ3Xdqqgo+ T1zeZVudyQ0NSg==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sR6Np-0007cc-PX; Tue, 09 Jul 2024 04:39:35 -0400 In-Reply-To: <87bk3c70jj.fsf@gmx.de> (Michael Albinus's message of "Fri, 05 Jul 2024 09:36:32 +0200") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321557 Archived-At: Michael Albinus writes: > Andrea Corallo writes: > > Hi Andrea, > >> Mmmh not sure is possible but also desirable, we want to be able to run >> as many tests as possible even with -jN. > > Last days, I've digged further into this. I still couldn't provoke the > error (my machine has only 8 processing units). However, ... > >>> Btw, could you check whether the D-Bus tests flickery goes away if we >>> tag dbus-test05-register-signal-with-nils as :unstable? >> >> From the bunch of test I did seems this is solving, I'll mark it as >> :unstable for now till a better solution is found. > > ... I've found suspicious code in this test. Usually, all tests work > deterministic. A method call or a signal is raised, and the returned > message from D-Bus is analyzed. But in this test, a signal handler with > a wildcard filter is registered. That means, *any* signal from D-Bus is > catched, also signals which aren't relevant for this test. The more > pressure you give on the system ("make -j96"), the more likely it is. > > So I have modified the signal handler to handle only signals we're > interested in. See the appended patch. Could you, pls, check whether it > helps? I guess we need it only in the master branch, because the problem > appears only in dbus-test.el. dbusbind.c and dbus.el are OK. Hi Michael, I tried your patch and seems to solve (for my few tries at least). But why do you think we need it only on master? Before being marked as unstable the test was flickering on emacs-30 as well. Thanks Andrea