From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: A lot of warnings building Emacs master Date: Sun, 27 Oct 2024 04:17:20 -0400 Message-ID: References: <1f4d1c5b-9077-4812-835d-06d3fa824154@libero.it> <86a5eqqt3b.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11522"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 27 09:17:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t4yTG-0002nw-Mh for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Oct 2024 09:17:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t4ySm-0003ED-ST; Sun, 27 Oct 2024 04:17:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4ySm-0003E4-1f for emacs-devel@gnu.org; Sun, 27 Oct 2024 04:17:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t4ySl-0006Ey-QN; Sun, 27 Oct 2024 04:17:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=GbNvYpD6pU1cyEKRqi3zHmx+4y91+7obwxWlbZY6xvM=; b=NAhKAz60SthHeL8dZCAd II14tEvka2SDgcJNlovYNhJbslb8yRhbgxkXyDzGlOdCFgPIjNfb1m8UykxdkAorqWZBepC2Dtv2Q FdE4qdgHJxjpeC//UihxTtdZEw/7ExdVFNoD4Z4s1t7Vn/6mfGsNf53GDuJRVR4IMJoZdePf04nHc JpiymIBYK8eCUlrofkuUNcoGvnKjgQwIGLWj64dLbeXRQ32nS4UuuxLiuGzXL0rew+0OSer9gRwi6 dyaTJ6MMz/BDWbipXfXB7LEsR6Lvkc+9ngWaTlRa8eodCF3hsNwLVw3Lddrp5CZt7RRSJ+q/yn474 O/T82JBr4RH8uQ==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1t4ySh-0000c6-Fk; Sun, 27 Oct 2024 04:17:27 -0400 In-Reply-To: <86a5eqqt3b.fsf@gmail.com> (Andy Moreton's message of "Sun, 27 Oct 2024 01:37:12 +0100") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324873 Archived-At: Andy Moreton writes: > On Sun 27 Oct 2024, Angelo Graziosi wrote: > >> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get >> about 10615 (grep -c ...) "Warning" like this: >> >> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*' >> instead. > > I see this also. The change to mark this as obsolete is premature. > > Marking as obsolete to avoid new uses being introduced should only be > done after reworking the existing codebase to remove the majority of > existing calls. > > The current situation of leaving hundreds of lines of warning noise in > the build output makes it harder to see other problems, and is not good. > > AndyM Agree, we should strive for pushing only warning free commits. I see Sean is putting effort in fixing this, but I often even see commits introducing new warnings in the hope that other contributors fix them in the future, this is not okay. That said I don't understand as well why was necessary to obsolete if-let in favor of if-let*, but bug#73853 has some reference to previous discussions (which I had no time to go through) and the change was agreed by a maintainer. Andrea