From: Andrea Corallo <acorallo@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: A lot of warnings building Emacs master
Date: Sun, 27 Oct 2024 04:17:20 -0400 [thread overview]
Message-ID: <yp18quaq7sf.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <86a5eqqt3b.fsf@gmail.com> (Andy Moreton's message of "Sun, 27 Oct 2024 01:37:12 +0100")
Andy Moreton <andrewjmoreton@gmail.com> writes:
> On Sun 27 Oct 2024, Angelo Graziosi wrote:
>
>> Building last master (commit 523aade3ea11c188e30e3889f031d1848129cf82) I get
>> about 10615 (grep -c ...) "Warning" like this:
>>
>> org-src.el: Warning: `if-let' is an obsolete macro (as of 31.1); use `if-let*'
>> instead.
>
> I see this also. The change to mark this as obsolete is premature.
>
> Marking as obsolete to avoid new uses being introduced should only be
> done after reworking the existing codebase to remove the majority of
> existing calls.
>
> The current situation of leaving hundreds of lines of warning noise in
> the build output makes it harder to see other problems, and is not good.
>
> AndyM
Agree, we should strive for pushing only warning free commits.
I see Sean is putting effort in fixing this, but I often even see
commits introducing new warnings in the hope that other contributors fix
them in the future, this is not okay.
That said I don't understand as well why was necessary to obsolete
if-let in favor of if-let*, but bug#73853 has some reference to previous
discussions (which I had no time to go through) and the change was
agreed by a maintainer.
Andrea
next prev parent reply other threads:[~2024-10-27 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 23:12 A lot of warnings building Emacs master Angelo Graziosi
2024-10-27 0:37 ` Andy Moreton
2024-10-27 6:22 ` Eli Zaretskii
2024-10-27 7:11 ` Sean Whitton
2024-10-27 8:30 ` Michael Albinus
2024-10-27 9:41 ` Stefan Kangas
2024-10-27 10:53 ` Sean Whitton
2024-10-27 7:06 ` Po Lu
2024-10-27 8:17 ` Andrea Corallo [this message]
2024-10-27 2:26 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp18quaq7sf.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.