From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#64646: Master: Native compiler doesn't always compile lambda forms. Date: Thu, 09 Nov 2023 05:08:59 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3642"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64646-done@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 09 11:09:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r11ym-0000ko-L7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Nov 2023 11:09:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r11yX-0003Ox-Ts; Thu, 09 Nov 2023 05:09:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r11yV-0003OL-RU for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 05:09:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r11yV-0003xP-JB for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 05:09:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r11z8-0003BY-9y for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 05:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Nov 2023 10:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64646 X-GNU-PR-Package: emacs Original-Received: via spool by 64646-done@debbugs.gnu.org id=D64646.169952459212223 (code D ref 64646); Thu, 09 Nov 2023 10:10:02 +0000 Original-Received: (at 64646-done) by debbugs.gnu.org; 9 Nov 2023 10:09:52 +0000 Original-Received: from localhost ([127.0.0.1]:46816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r11yu-0003B1-Hj for submit@debbugs.gnu.org; Thu, 09 Nov 2023 05:09:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r11yr-0003Al-IK for 64646-done@debbugs.gnu.org; Thu, 09 Nov 2023 05:09:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r11y9-0003qO-26; Thu, 09 Nov 2023 05:09:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=BMKofEPAoUYN8V9uQIYV4bW7hQBrcifYCPXZwi3tBSQ=; b=ScfhvideliGZCIKOxLQT WK1So28tstKHZR82jWSp/lnyCDkKVMyBX9qggSNTJWPrPOD9u/SPXEjvFtPsgNkQHO/E1dH5WOH2w ioUi6+JKOs6CpNnF/KbMtzrDpQTcC2EURKE38/gfFW9XxxrZu5jNwMie9diVzY51xei1YC84i8Qua +WEUVQ8pIngFm9pnBhf6cCYQxKWOKeBSjNwC8+HAdKozTc9J0uI8845pl0bi3LoW4Pn9ilBhVBgj9 3kIPyCG5/8x5UF22cIYGPmvBkoc1E+mBO5yx7uGFGItrMQhVGmFlaPntRkEdyl6Ar3YoPHDsF0v3h atr1+eeISNC5/w==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1r11y7-0001Uu-3n; Thu, 09 Nov 2023 05:09:00 -0500 In-Reply-To: (Alan Mackenzie's message of "Wed, 8 Nov 2023 20:59:42 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274041 Archived-At: Alan Mackenzie writes: > Hello, Andrea. > > On Thu, Nov 02, 2023 at 13:32:21 -0400, Andrea Corallo wrote: >> Alan Mackenzie writes: > >> > This bug doesn't seem to be moving, so .... > >> > On Wed, Jul 26, 2023 at 10:57:01 -0400, Andrea Corallo wrote: >> >> Alan Mackenzie writes: > >> >> >> I'm not 100% convinced this behaviour is a bug tho. > >> >> > I don't understand that. Why might it be incorrect to compile that inner >> >> > lambda natively? > >> >> Hi Alan, > >> >> I'm not saying it would be incorrect. I'm suggesting that if is not >> >> specified what's the expected behaviour of compiling by name the outer >> >> lambda it might not be a bug. > >> >> When we compile a whole compilation unit we indeed have to compile all >> >> functions, in this case what we promised is I think not defined. > >> > I still don't understand that. The doc string for native-compile says: > >> > Compile FUNCTION-OR-FILE into native code. > >> > .. I can't see any reason not also to compile inner lambda functions >> > natively. > >> > Anyhow, to fix this bug (if such it be) is easy: > >> > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el >> > index 181e5ca96a1..2360fbaa494 100644 >> > --- a/lisp/emacs-lisp/comp.el >> > +++ b/lisp/emacs-lisp/comp.el >> > @@ -1359,7 +1359,12 @@ comp-add-func-to-ctxt >> > (comp-ctxt-top-level-forms comp-ctxt) >> > (list (make-byte-to-native-func-def :name function-name >> > :c-name c-name))) >> > - (comp-add-func-to-ctxt func)))) >> > + (comp-add-func-to-ctxt func)) >> > + ;; Handle any lambda functions in BYTE-CODE. >> > + (maphash (lambda (key val) >> > + (unless (eq key (aref byte-code 1)) >> > + (comp-intern-func-in-ctxt key val))) >> > + byte-to-native-lambdas-h))) > >> > (cl-defmethod comp-spill-lap-function ((form list)) >> > "Byte-compile FORM, spilling data from the byte compiler." > > >> > What do you say? > >> LGTM as long as indeed it does not regress any test. Speaking of which >> with the patch I guess we want a test to cover this. > > Thanks. I've committed a patch for this, including two extra tests which > test that a nested lambda function also gets native compiled. > > I'm closing the bug with this post. > >> > Incidentally, the code in the various comp-spill-lap-function methods >> > together with comp-intern-func-in-ctxt appears to have some code >> > duplication. Would it be possible to have the symbol and list methods of >> > comp-spill-lap-function simply call comp-intern-func-in-ctxt the way the >> > string method does? That would simplify those two methods quite a bit. > >> Mmmh maybe, I think one has to try to see if the result is satisfactory. > > I've done this refactoring too. The symbol and list methods for > comp-spill-lap-function now have 17 and 15 lines respectively. I hope > you like it! Look nice thanks! Andrea