From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 74bb1e5897f 2/3: Fix filling in c-ts-mode (bug#72116) Date: Mon, 05 Aug 2024 05:22:07 -0400 Message-ID: References: <172238461549.32268.17283604138559769854@vcs2.savannah.gnu.org> <20240731001020.DEFADC1CAE9@vcs2.savannah.gnu.org> <8F99C2F8-F88E-4662-B2E8-70592DBAEAC8@gmail.com> <171796ED-921A-472C-8682-C1252EA265B0@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13518"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Emacs Devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 05 11:23:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1satvi-0003M3-Ti for ged-emacs-devel@m.gmane-mx.org; Mon, 05 Aug 2024 11:23:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1satux-0003uF-VQ; Mon, 05 Aug 2024 05:22:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1satuq-0003tj-GW for emacs-devel@gnu.org; Mon, 05 Aug 2024 05:22:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1satup-0002og-QF; Mon, 05 Aug 2024 05:22:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=24KbZ4zUQXLm4SPOo3jR30iwzIDbkwB7tCwqmbU0xek=; b=qw6wZlcZ/Q7S4WMVDmqQ 3pXeI1YNiDRsM2ZSNYebVyE33B/dPb49697Q2l+2sMmoQ9h20X2D0coDujMAxwMOfcnDKUpZbuNwz 5TreHoe7OFPbR//gyO/qyZQ7KKT9pr3Y/ARCaj1yokf67gtNSTE9+G/+xMlsKMqTik7jD5qD7w4OI Zlyy75wCQQohXrpA+kYOPvJEBa0iQVWC8cktxUS6N8R+tqOltHAhEyZ6PMKT7KAWq8ZUl9uicqFTx lXGsgYlGedp2kRDIQZAsKUrghyreV2mKUMqHdztpQrlJsThoFCiyDcRFUETHS3Pv5Y7WaRyDLdyUj NR4k+Z/F4SJT7A==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1satup-0004vT-Jw; Mon, 05 Aug 2024 05:22:07 -0400 In-Reply-To: <171796ED-921A-472C-8682-C1252EA265B0@gmail.com> (Yuan Fu's message of "Sun, 4 Aug 2024 20:50:41 -0700") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322352 Archived-At: Yuan Fu writes: >> On Aug 3, 2024, at 12:30=E2=80=AFAM, Yuan Fu wrote: >>=20 >>=20 >>=20 >>> On Aug 1, 2024, at 1:53=E2=80=AFAM, Andrea Corallo w= rote: >>>=20 >>> Yuan Fu writes: >>>=20 >>>> branch: master >>>> commit 74bb1e5897f4532fbdefddada28258a8d3d5c95f >>>> Author: Yuan Fu >>>> Commit: Yuan Fu >>>>=20 >>>> Fix filling in c-ts-mode (bug#72116) >>>>=20 >>>> The previous fix introduced a regression in the case when there's on= ly a >>>> single line in the block comment. In that case we don't want to add= a >>>> start at the second line: >>>>=20 >>>> /* foo foo foo */ should =3D> /* foo foo >>>> foo */ >>>>=20 >>>> rather than /* foo foo >>>> * foo */ >>>>=20 >>>> This commit fixes that. >>>>=20 >>>> * lisp/progmodes/c-ts-common.el: >>>> (c-ts-common--fill-block-comment): Don't mask the /*. >>>> (c-ts-common--adaptive-fill-prefix): New function. >>>> (c-ts-common-comment-setup): Don't set adaptive-regexp, change >>>> adaptive-fill-first-line-regexp to work with the new >>>> adaptive-fill-function. >>>> * test/lisp/progmodes/c-ts-mode-resources/filling.erts: New tests >>>=20 >>> Hi Yuan, >>>=20 >>> this change is causing the following regression on my testbench on >>> master: >>>=20 >>> c-ts-mode-test-filling >>> 1/4 c-ts-mode-test-filling (0.015896 sec) at lisp/progmodes/c-ts-mode-= tests.el:38 >>>=20 >>> Would you mind having a look? >>>=20 >>> Thanks >>=20 >> Yes absolutely, wonder why it didn=E2=80=99t error when I wrote the patc= h :-( > > Ok, should be fixed now. > > Yuan Confirm thanks!