From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo <acorallo@gnu.org> Newsgroups: gmane.emacs.devel Subject: Re: master f92520d009e 1/2: Don't pause display for pending input Date: Thu, 19 Dec 2024 07:04:06 -0500 Message-ID: <yp15xnfangp.fsf@fencepost.gnu.org> References: <173460276132.331083.7195719813421951970@vcs3.savannah.gnu.org> <20241219100603.94BA7C031EB@vcs3.savannah.gnu.org> <yp1a5cs9c80.fsf@fencepost.gnu.org> <m24j2z9b28.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30669"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Gerd =?utf-8?Q?M=C3=B6llmann?= <gerd@gnu.org> To: Gerd =?utf-8?Q?M=C3=B6llmann?= <gerd.moellmann@gmail.com> Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 19 13:04:42 2024 Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org> Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>) id 1tOFGj-0007oH-Ci for ged-emacs-devel@m.gmane-mx.org; Thu, 19 Dec 2024 13:04:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <emacs-devel-bounces@gnu.org>) id 1tOFGU-0004JB-WC; Thu, 19 Dec 2024 07:04:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <acorallo@gnu.org>) id 1tOFGB-0004Ij-78 for emacs-devel@gnu.org; Thu, 19 Dec 2024 07:04:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <acorallo@gnu.org>) id 1tOFGA-0005je-Rp; Thu, 19 Dec 2024 07:04:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=D00RtrBZz+zCL+H+LSsDbI2QKhEGxXXsDpQ3hUKSEq4=; b=MdQN+VU4IuA34TeEubcD 9RQYTVYv1JFQNt7lkf1M1ZMkRy7JxovWNy3lZciBDXsgIMdT9ms2s82ckmcdNfyLR7YpyVwtswoiA G38KMBnZKLdlfuSo+Lb9xtd8/saByfkclyIukpQMGYdh7T4IytDlWu32Tp4K6IKB2fFU9JjKbNPkU OAiJRUJ/qQWuW3VNyQsChGiYHVEOh0OOxZ5/gEqFg8fl2F69VhRIT0gOHCg/GutncrBQQ5kiIlJOi e0cfaaUut3IHCqPjpwird69MqvEfmfxLNROycW+rJU5Zv/FSVsU0zP74rFZdUZqVvS2g00YtTGaIv xdpoDleQmjl4aA==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from <acorallo@gnu.org>) id 1tOFGA-0003OQ-Fa; Thu, 19 Dec 2024 07:04:06 -0500 In-Reply-To: <m24j2z9b28.fsf@gmail.com> ("Gerd =?utf-8?Q?M=C3=B6llmann=22'?= =?utf-8?Q?s?= message of "Thu, 19 Dec 2024 12:17:19 +0100") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." <emacs-devel.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>, <mailto:emacs-devel-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/emacs-devel> List-Post: <mailto:emacs-devel@gnu.org> List-Help: <mailto:emacs-devel-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>, <mailto:emacs-devel-request@gnu.org?subject=subscribe> Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326731 Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/326731> Gerd M=C3=B6llmann <gerd.moellmann@gmail.com> writes: > Andrea Corallo <acorallo@gnu.org> writes: > >> Gerd Moellmann <gerd@gnu.org> writes: >> >>> branch: master >>> commit f92520d009e1ab8024b03d9d71ecc9820573c040 >>> Author: Gerd M=C3=B6llmann <gerd@gnu.org> >>> Commit: Gerd M=C3=B6llmann <gerd@gnu.org> >>> >>> Don't pause display for pending input >>> >>> * src/dispnew.c: Remove display_completed, redisplay_dont_pause, >>> redisplay-dont-pause was declared obsolete in Emacs 24. Remove any= thing >>> checking pending input, change function signatures accordingly, and= so >>> on. >>> >>> * src/keyboard.c (read_char): Don't use redisplay_dont_pause. >>> * src/minibuf.c (read_minibuf): Use new function signatures. >>> * src/xdisp.c: Don't check display_completed. Use new API. >>> >>> * lisp/subr.el (redisplay-dont-pause): Remove declaration. >> >> I think instances of 'Qredisplay_dont_pause' are still present in the >> codebase so some build configurations are now broken (at least my >> GNU/Linux one). >> >> =3D=3D=3D=3D=3D >> xterm.c:6372:13: error: =E2=80=98Qredisplay_dont_pause=E2=80=99 undeclar= ed (first use in this function) >> 6372 | specbind (Qredisplay_dont_pause, Qt); >> | ^~~~~~~~~~~~~~~~~~~~~ >> xterm.c:6372:13: note: each undeclared identifier is reported only once = for each function it appears in >> xfns.c: In function =E2=80=98Fx_print_frames_dialog=E2=80=99: >> xfns.c:9967:13: error: =E2=80=98Qredisplay_dont_pause=E2=80=99 undeclare= d (first use in this function) >> 9967 | specbind (Qredisplay_dont_pause, Qt); >> | ^~~~~~~~~~~~~~~~~~~~~ >> xfns.c:9967:13: note: each undeclared identifier is reported only once f= or each function it appears in >> =3D=3D=3D=3D=3D >> >> Could you have a look? >> >> Thanks > > Thanks, should be fixed now. On a61b968ccfe8fa7e2f1fcf7667781a1c0527389a I see now with --with-native-compilation=3Dno --with-x-toolkit=3Dno =3D=3D=3D=3D=3D dispnew.c: In function =E2=80=98update_menu_bar=E2=80=99: dispnew.c:3760:5: error: too many arguments to function =E2=80=98update_win= dow=E2=80=99 3760 | update_window (XWINDOW (f->menu_bar_window), true); | ^~~~~~~~~~~~~ dispnew.c:97:13: note: declared here 97 | static void update_window (struct window *); | ^~~~~~~~~~~~~ =3D=3D=3D=3D=3D=3D=3D And with --enable-checking=3Dall --enable-check-lisp-object-type --with-nat= ive-compilation=3Dyes =3D=3D=3D=3D=3D=3D=3D In file included from dispnew.c:27: In function =E2=80=98PSEUDOVECTORP=E2=80=99, inlined from =E2=80=98FRAMEP=E2=80=99 at lisp.h:3343:10, inlined from =E2=80=98FRAME_PARENT_FRAME=E2=80=99 at frame.h:1236:42, inlined from =E2=80=98root_frame=E2=80=99 at dispnew.c:3340:10, inlined from =E2=80=98is_in_matrix=E2=80=99 at dispnew.c:3877:24, inlined from =E2=80=98is_cursor_obscured=E2=80=99 at dispnew.c:3898:8, inlined from =E2=80=98terminal_cursor_magic=E2=80=99 at dispnew.c:3917:= 7, inlined from =E2=80=98combine_updates_for_frame=E2=80=99 at dispnew.c:3= 970:5: lisp.h:1096:68: warning: null pointer dereference [-Wnull-dereference] 1096 | && ((XUNTAG (a, Lisp_Vectorlike, union vectorlike_header)= ->size | ^ =3D=3D=3D=3D=3D=3D=3D Thanks