From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Native compilation on as default? Date: Thu, 29 Feb 2024 05:56:31 -0500 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33874"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , stefankangas@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 29 11:57:37 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfe6a-0008aF-3m for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Feb 2024 11:57:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfe5i-0002FY-D8; Thu, 29 Feb 2024 05:56:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfe5h-0002Dp-Co for emacs-devel@gnu.org; Thu, 29 Feb 2024 05:56:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfe5h-0006m7-3M; Thu, 29 Feb 2024 05:56:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=y9dCXR+KfDL49nMclNo8kc6WbeObQwBV8F6GV28F+HY=; b=FiYyfqR8ZwYKlU YFNq3EggWEU9GSW4St6S8cTVjcKQTG7ZaVQ/sSqMOb6en3dUJFghofXTx8upj98SndJ39uC9ycEXM Rsik4LUO5Ieg4HcQq+4j5tpxO7+P2lF2dBf4cfmIfJyE77l0SvyEJ2HME+AIWGkV+DD2uVVeBiCZ3 hI0tNr6WuhI+pODPlCNDI7hX9oqUxYush3TCx/jHnLR87RO/eqMZJ52tecPBFYa8T0iPQ6Q85iX4H JaauymkQhNumjBiPyX0JixJbCLdYsZN0tN9ggVmVgrbCmbti+I12dE1XrJxd3WVKQa8dEGJDweb9K 55HUb2+DD/86kJs8rorw==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rfe5Y-0005mQ-CP; Thu, 29 Feb 2024 05:56:40 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316638 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: Eli Zaretskii , emacs-devel@gnu.org >> Date: Wed, 25 Oct 2023 16:50:17 -0400 >> >> So I think we could have a new mode, still controlled by >> native-comp-async-report-warnings-errors, that filters out all the >> uninteresting warnings (that the programmer already got during byte >> compilation) but still report this important one. >> >> So even if the package developer doesn't use native compilation it can >> get the bug report for the issue. >> >> I suspect this might be a good compromise/solution. >> >> WDYT? > > Sounds like a plan to me, thanks. Back on this, Okay I've implemented the functionality with 8e5baaddec2. I was in doubt of adding a new value to 'native-comp-async-report-warnings-errors' or add a new knob, but what we report seemed to me orthogonal to how we do it, so I went for the second option introducing 'native-comp-async-report-warnings-errors-kind'. I we decide it's not optimal I don't feel strong about it and I'm happy to change the approach. Anyway with this change as per default we report only important warnings and (all) errors, and we do it presenting the *Warnings* buffer to the user (which I believe this is the behavior we wanted). Indeed if something can be improved in the nomenclature or the doc feel free to do it or come with suggestions. Thanks! Andrea