From: Andrea Corallo <acorallo@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alvaro Ramirez <alvaro@xenodium.com>,
72272@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#72272: [PATCH] dired-hide-details-mode hides directory's absolute path
Date: Mon, 05 Aug 2024 05:45:29 -0400 [thread overview]
Message-ID: <yp134njmhfq.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <86plqosoem.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Aug 2024 11:06:09 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Alvaro Ramirez <alvaro@xenodium.com>
>> Date: Wed, 24 Jul 2024 12:17:58 +0100
>>
>> Hi folks,
>>
>> Sending an initial patch. Happy to iterate on it, add tests,
>> etc. if we
>> reckon the feature is worth pursuing.
>>
>> Set `dired-hide-details-hide-absolute-location` to non-nil and
>> toggle
>> `dired-hide-details-mode` to hide the current directory's absolute
>> path.
>>
>> This is my first submission, might need some process guidance.
>
> Thanks.
>
> Stefan and Andrea, any comments?
>
> I have a few minor ones:
>
>> From: xenodium <me+gh@xenodium.com>
>> Date: Tue, 23 Jul 2024 21:55:37 +0100
>> Subject: [PATCH] Hides current location's path via dired-hide-details-mode
> ^^^^
> Please don't use "path" for anything except PATH-style directory
> lists. The GNU Coding Standards frown on such usage.
>
>> +(defcustom dired-hide-details-hide-absolute-location t
>> + "Non-nil means `dired-hide-details-mode' hides current location's absolute path."
>
> Same here.
>
>> + (if-let ((dir-base (file-name-nondirectory new-dir-name))
>> + (dir-path (file-name-directory new-dir-name))
>> + (hide-dir-path (and dired-hide-details-hide-absolute-location
>
> And here.
>
> Also, this change needs a NEWS entry.
No further comments other than:
> @@ -3268,6 +3275,11 @@ dired-hide-details-update-invisibility-spec
> 'add-to-invisibility-spec
> 'remove-from-invisibility-spec)
> 'dired-hide-details-information)
> + (funcall (if (and dired-hide-details-mode
> + dired-hide-details-hide-absolute-location)
> + 'add-to-invisibility-spec
> + 'remove-from-invisibility-spec)
> + 'dired-hide-details-absolute-location)
don't we favor #' in place of ' when quoting functions?
Thanks
Andrea
next prev parent reply other threads:[~2024-08-05 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 11:17 bug#72272: [PATCH] dired-hide-details-mode hides directory's absolute path Alvaro Ramirez
2024-08-04 8:06 ` Eli Zaretskii
2024-08-05 9:45 ` Andrea Corallo [this message]
[not found] ` <d75b2eb4e45413d468c15f4d6e8c3d0ce568d28ddbf7a828a4f917f29e54cbcb@mu.id>
2024-08-05 14:34 ` Alvaro Ramirez
2024-08-17 8:53 ` Eli Zaretskii
2024-08-17 9:27 ` Alvaro Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp134njmhfq.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=72272@debbugs.gnu.org \
--cc=alvaro@xenodium.com \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.