Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps

Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps

[Andrea Corallo]

Jim Porter <jporterbugs@gmail.com> writes:

> branch: master
> commit b573aaab76b55ec276b9190570b3ca3ae72cb416
> Author: Jim Porter <jporterbugs@gmail.com>
> Commit: Jim Porter <jporterbugs@gmail.com>
>
>     ; Make utility functions for getting the Eshell non-special regexps
>     
>     * lisp/eshell/esh-arg.el (eshell-inside-quote-regexp)
>     (eshell-outside-quote-regexp): Rename to...
>     (eshell--non-special-inside-quote-regexp)
>     (eshell--non-special-outside-quote-regexp): ... these, and add
>     defsubsts.
>     (eshell-arg-initialize): Don't initialize regexp variables.
>     (eshell-parse-non-special): ... use them.
>     
>     * lisp/eshell/em-glob.el (eshell-glob-chars-regexp): Use 'rx-to-string'.

Hi Jim,

If I'm not wrong this commit once merged into master is causing the
following warnings:

eshell/em-script.el:75:9: Warning: Unused lexical variable
‘eshell-outside-quote-regexp’

eshell/em-script.el:74:9: Warning: Unused lexical variable
‘eshell-inside-quote-regexp’

Would you ming having a look?

Thanks!

  Andrea

Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps

[Jim Porter]

On 10/21/2024 1:00 AM, Andrea Corallo wrote:
> If I'm not wrong this commit once merged into master is causing the
> following warnings:
> 
> eshell/em-script.el:75:9: Warning: Unused lexical variable
> ‘eshell-outside-quote-regexp’
> 
> eshell/em-script.el:74:9: Warning: Unused lexical variable
> ‘eshell-inside-quote-regexp’
> 
> Would you ming having a look?

Thanks for letting me know. It turns out there was an actual bug here 
that my previous change helped reveal: the previous code was trying to 
work around the fact that the Eshell startup scripts were running before 
the Eshell session was fully-initialized, which is iffy at best.

I've now changed this so that there's a new 
'eshell-after-initialize-hook' that em-script.el can use. That's more 
correct and lets us avoid the let-binding that caused this warning.

Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps

[Andrea Corallo]

Jim Porter <jporterbugs@gmail.com> writes:

> On 10/21/2024 1:00 AM, Andrea Corallo wrote:
>> If I'm not wrong this commit once merged into master is causing the
>> following warnings:
>> eshell/em-script.el:75:9: Warning: Unused lexical variable
>> ‘eshell-outside-quote-regexp’
>> eshell/em-script.el:74:9: Warning: Unused lexical variable
>> ‘eshell-inside-quote-regexp’
>> Would you ming having a look?
>
> Thanks for letting me know. It turns out there was an actual bug here
> that my previous change helped reveal: the previous code was trying to
> work around the fact that the Eshell startup scripts were running
> before the Eshell session was fully-initialized, which is iffy at
> best.
>
> I've now changed this so that there's a new
> 'eshell-after-initialize-hook' that em-script.el can use. That's more
> correct and lets us avoid the let-binding that caused this warning.

Thanks

  Andrea