From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Native compilation on as default? Date: Wed, 25 Oct 2023 16:50:17 -0400 Message-ID: References: <83legs281v.fsf@gnu.org> <83r0liiy44.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9910"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 25 22:51:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvkqN-0002PO-Br for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Oct 2023 22:51:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvkpX-0006Xp-Oq; Wed, 25 Oct 2023 16:50:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvkpW-0006Dw-0O for emacs-devel@gnu.org; Wed, 25 Oct 2023 16:50:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvkpV-0004jO-Nz; Wed, 25 Oct 2023 16:50:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=/VdIsDGyiw3Ii0Yt+ZbFFOwBG2ZrRz64eoBgd5O7cpU=; b=lWQgzaEB4L5PBl6L1N+m ziTyl6onoNFREuBxVa/YOXGySw9iygSBIv2vVvglyCBcl5LQqcPuzMPiClHUrc4PES4fEuK1pGmEN JIUPv/tbMye8UFwYrXBN9hwaBh7G8Zr7oqOTGBfX/GBp1OlLTNwrL8sTTEbABLOOU4tIsFw7Ercjs WYq+NCNibibiXj6AaezLPnSP/WAD5c5HHEjO5yRM6cQwEKKHEYdeZvAp33OzJc02hXaI6trd3lZMA T8o6CbJ+oUWnmQd+uOWeKenTW1OT30CXtBIndNii7vk+adchW1OMzbt3cfTDXVbFeqKD6+4E4Zw8d onbxyYPqlnss1w==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qvkpV-0006iA-HZ; Wed, 25 Oct 2023 16:50:17 -0400 In-Reply-To: (Stefan Kangas's message of "Wed, 25 Oct 2023 07:42:43 -0700") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311864 Archived-At: Stefan Kangas writes: > Eli Zaretskii writes: > >>> 29.2 pretest out reminded me I promised to ping this thread so here I'm >>> :) >> >> Stefan, what is your opinion on this? > > I see no reason not to enable native-comp by default in Emacs 30.1. > > We have had it as an optional for a full major release already, and it > is enabled by default in several major GNU/Linux distributions. Some of > us have been using it for a full year or more before that. It seems > stable enough. > > I think we should take the chance to also change the default of > 'native-comp-async-report-warnings-errors' to nil. It is much too > intrusive for general use, and effectively duplicates the warnings users > already see during package installation. Thinking about this... IME *the* warning we are interested in from the async compilation is the: "the function =E2=80=98xxx=E2=80=99 is not known to be defined." This because typically xxx is not a function but a macro and is unknown due to a missing require, the file end-up misscompiled and not functional. So I think we could have a new mode, still controlled by native-comp-async-report-warnings-errors, that filters out all the uninteresting warnings (that the programmer already got during byte compilation) but still report this important one. So even if the package developer doesn't use native compilation it can get the bug report for the issue. I suspect this might be a good compromise/solution. WDYT? Andrea