From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions Date: Mon, 04 Mar 2024 04:36:45 -0500 Message-ID: References: <170950733941.30552.13228431602613197760@vcs2.savannah.gnu.org> <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34405"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 04 10:37:37 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rh4lM-0008lB-Je for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Mar 2024 10:37:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rh4ki-0003gk-8T; Mon, 04 Mar 2024 04:36:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh4kg-0003gA-FS for emacs-devel@gnu.org; Mon, 04 Mar 2024 04:36:54 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh4ke-000726-Q3; Mon, 04 Mar 2024 04:36:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=7Sm9r0o5l8LbRxuGXplvBwXdf3PIbFFAKmOhMJ4xX68=; b=rm5SX03umXp00S9BNzp6 lbAB7bBBaLSQwKO2UOFdt90WWKqOPqlnaOnTsTfI76738uwNgk9JM5PH+vpRrPHxDL2lAZYjbNaAM RBVkZK/K7UtKvoHaQaGmBK/T4wORzDtROh6ZgHETn6Nd8hajAi5W+mHjbTOILlsg/R6mTv1MD8i8v c9u2Prc8WOWVmwlV1sjd941jyGdcRYnez62fpYgEO08DEinU3ab5KM9oZIld/U7v9O36TLWyxNvQI 1sdKDmx15JT6AMkW21rbT1Qgfbd80Dz8wlM7FstFtzDAje4UpNg3zRezBafmels5q9yK++JpCkKSL EnocUYLF5sXcow==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1rh4kY-00033o-Hi; Mon, 04 Mar 2024 04:36:50 -0500 In-Reply-To: <20240303230900.51D39C12C5F@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Sun, 3 Mar 2024 18:09:00 -0500 (EST)") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316784 Archived-At: Stefan Monnier via Mailing list for Emacs changes writes: > branch: master > commit 1d9d07fb00e6b62641c07af68f986e700b5f6cee > Author: Stefan Monnier > Commit: Stefan Monnier > > (cl--typeof-types): Rework to fix some regressions > > Initialize the variables directly in their declaration, so > there no time where they exist but aren't yet initialized. > This also allows us to mark `cl--typeof-types` as a `defconst` again. > > More importantly, specify the DAG by direct supertypes rather > than direct subtypes. This is slightly less compact, but it's > necessary to let us specify the *order* of the supertypes, > which is necessary for example to preserve the desired ordering > of methods when several methods can be applied. Hi Stefan, I'm not sure I understand. Is some code relying on the "order" of the supertypes? Are these the regression you are mentioning? Must say I'm surprised supertypes can have an "order" in first place. Thanks Andrea