From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#71934: 31.0.50; edebug--called-interactively-skip vs. new fun objects Date: Fri, 05 Jul 2024 04:46:05 -0400 Message-ID: References: <877ce17ncn.fsf@web.de> <87sewo5vym.fsf@web.de> <87zfqwh1gb.fsf@web.de> <86o77c75jd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38496"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Heerdegen , 71934-done@debbugs.gnu.org, monnier@iro.umontreal.ca, acm@muc.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 05 10:47:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPebI-0009nb-Pv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jul 2024 10:47:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeb3-0000s4-2a; Fri, 05 Jul 2024 04:47:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeap-0000q7-M7 for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 04:47:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeap-00049v-C6 for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 04:46:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPear-000552-Vx for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2024 04:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2024 08:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71934 X-GNU-PR-Package: emacs Original-Received: via spool by 71934-done@debbugs.gnu.org id=D71934.172016918119475 (code D ref 71934); Fri, 05 Jul 2024 08:47:01 +0000 Original-Received: (at 71934-done) by debbugs.gnu.org; 5 Jul 2024 08:46:21 +0000 Original-Received: from localhost ([127.0.0.1]:43559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPeaD-000543-BH for submit@debbugs.gnu.org; Fri, 05 Jul 2024 04:46:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPeaB-00053p-CH for 71934-done@debbugs.gnu.org; Fri, 05 Jul 2024 04:46:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPea1-00045T-VC; Fri, 05 Jul 2024 04:46:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=B5HcULvH5PsHFoxBvbMtljVSND+lOJaoXzHIMrrf6v4=; b=qNVZZUUue5geMervoNia 4M3aTmR/BwvdOo/9diUTR1n7oby0m/rpQpmUvIVX/pebAwYsVaz1dbscI/hfhjRdeqOKkILFjbJxY GrLvpCDqxP9LC/acdskkVkmz0QWixdQGQgFjkgChhu1s9b1vQAsLvlvObtEkQWVq/KQC1LaIQtSXV YKU1cBt+RYBO8PwOPQvQhXVuDCE6rMdjo+6N2PwmMCpj01N4rt3hbLeMAEy1GjWJ4JCiT79+0p3yF 0kTEroaAvP6cjdUBRpwvnSj3CajTSkYiJ+q9xIV8pU/L1Cmqf05wsM3TT7skAtPRIz+rOT4iVeJlv Pb7jIE2sKLAV3A==; Original-Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sPeZx-0000qK-AY; Fri, 05 Jul 2024 04:46:09 -0400 In-Reply-To: <86o77c75jd.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jul 2024 08:48:38 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288415 Archived-At: Eli Zaretskii writes: >> Cc: 71934-done@debbugs.gnu.org, Alan Mackenzie >> Date: Fri, 05 Jul 2024 07:06:44 +0200 >> From: Michael Heerdegen via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Stefan Monnier writes: >> >> > I already did. >> >> What about `which-key--get-keymap-bindings-1'? >> >> >> For this one I CC Alan M.: >> >> > There's one case on `comp.el` which may require some update >> >> Yes, that's more or less the only other one I found: >> `comp--spill-lap-function'. Alan, we are discussing how relevant the >> code in that function is that checks for lambda and closure cars, and if >> it must be updated to handle the new interpreted function objects. >> >> > but I don't understand the code enough to know what it intends to >> > do. It seems to match both `lambda` and `closure`, hence function >> > *values*, but somehow it doesn't try and handle byte-code functions >> > which are far more common function values, so maybe the `closure` is >> > just irrelevant and the code is expected to match source code >> > expressions (whose evaluation will return functions)? >> >> Dunno. `comp-trampoline-compile' constructs a lambda form to compile. >> But never a "closure form". So maybe irrelevant to check for 'closure' >> indeed. >> >> Alan had added the 'closure' symbol in >> >> 06e4ebc81a4 "With `native-compile', compile lambdas in a defun or lambda too" >> >> which seems had been a fix for bug#64646 "Master: Native compiler >> doesn't always compile lambda". Guess this bug report is also an answer >> to Stefan's question. > > Andrea, can you take a look at this, please? Yep, I believe that code does not require to be changed, the input of comp--spill-lap-function is a form not an interpred function. Andrea