bug#1035: 23.0.60; DOS eol decoding bug

bug#1035: 23.0.60; DOS eol decoding bug

[Johan =?UTF-8?Q?Bockg=C3=A5rd]

Decoding a chunk of DOS text that ends in \r results in an extra chunk
of garbage.

    (progn
      (with-temp-file "/tmp/bar"
        (insert-char ?x 10)
        (insert "\r"))
      (with-temp-buffer
        (let ((coding-system-for-read 'raw-text-dos))
          (insert-file-contents "/tmp/bar")
          (buffer-size))))

      => 21 (expected result 11)


I think the problem was introduced with this change:

2008-03-02  Kenichi Handa  <handa@m17n.org>

    * coding.c (decode_coding_utf_8): When eol-type of CODING is `dos',
    don't decode '\r' if that is the last in the source.
    (decode_coding_utf_16, decode_coding_emacs_mule)
    (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
    (decode_coding_raw_text, decode_coding_charset): Likewise.
    (produce_chars): Don't decode EOL here. Use EMACS_INT.

-- 
Johan Bockgård

bug#1035: marked as done (23.0.60; DOS eol decoding bug)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]


Your message dated Sat, 20 Dec 2008 16:02:54 +0800
with message-id <494CA6AE.9070609@gnu.org>
and subject line Re: bug#1035: 23.0.60; DOS eol decoding bug
has caused the Emacs bug report #1035,
regarding 23.0.60; DOS eol decoding bug
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1035: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1035
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2937 bytes --]

From: bojohan+mail@dd.chalmers.se (Johan Bockgård)
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; DOS eol decoding bug
Date: Fri, 26 Sep 2008 22:34:12 +0200
Message-ID: <yoijzlluir3v.fsf@remote5.student.chalmers.se>


Decoding a chunk of DOS text that ends in \r results in an extra chunk
of garbage.

    (progn
      (with-temp-file "/tmp/bar"
        (insert-char ?x 10)
        (insert "\r"))
      (with-temp-buffer
        (let ((coding-system-for-read 'raw-text-dos))
          (insert-file-contents "/tmp/bar")
          (buffer-size))))

      => 21 (expected result 11)


I think the problem was introduced with this change:

2008-03-02  Kenichi Handa  <handa@m17n.org>

    * coding.c (decode_coding_utf_8): When eol-type of CODING is `dos',
    don't decode '\r' if that is the last in the source.
    (decode_coding_utf_16, decode_coding_emacs_mule)
    (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
    (decode_coding_raw_text, decode_coding_charset): Likewise.
    (produce_chars): Don't decode EOL here. Use EMACS_INT.

-- 
Johan Bockgård



[-- Attachment #3: Type: message/rfc822, Size: 2975 bytes --]

From: Jason Rumney <jasonr@gnu.org>
To: "Johan Bockgård" <bojohan+mail@dd.chalmers.se>, 1035-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1035: 23.0.60; DOS eol decoding bug
Date: Sat, 20 Dec 2008 16:02:54 +0800
Message-ID: <494CA6AE.9070609@gnu.org>

Johan Bockgård wrote:
> Decoding a chunk of DOS text that ends in \r results in an extra chunk
> of garbage.
>   

Thanks for reporting it, I have fixed this now.