From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: bojohan+news@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=) Newsgroups: gmane.emacs.devel Subject: Re: Idle timers with the active minibuffer Date: Sat, 10 Nov 2007 00:21:55 +0100 Message-ID: References: <87k5otd3jx.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1194650549 27970 80.91.229.12 (9 Nov 2007 23:22:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Nov 2007 23:22:29 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 10 00:22:33 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IqdBI-0000Kk-Lt for ged-emacs-devel@m.gmane.org; Sat, 10 Nov 2007 00:22:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqdB6-0000fg-Uw for ged-emacs-devel@m.gmane.org; Fri, 09 Nov 2007 18:22:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IqdB3-0000cZ-6X for emacs-devel@gnu.org; Fri, 09 Nov 2007 18:22:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IqdB2-0000aY-70 for emacs-devel@gnu.org; Fri, 09 Nov 2007 18:22:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IqdB2-0000aD-01 for emacs-devel@gnu.org; Fri, 09 Nov 2007 18:22:16 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IqdB1-00041k-AN for emacs-devel@gnu.org; Fri, 09 Nov 2007 18:22:15 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IqdAs-0003yh-Dv for emacs-devel@gnu.org; Fri, 09 Nov 2007 23:22:06 +0000 Original-Received: from remote4.student.chalmers.se ([129.16.29.77]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 09 Nov 2007 23:22:06 +0000 Original-Received: from bojohan+news by remote4.student.chalmers.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 09 Nov 2007 23:22:06 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 49 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: remote4.student.chalmers.se Mail-Copies-To: never User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) Cancel-Lock: sha1:kQkJhGj/LbXAFgT/PqZxsdag5PQ= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82891 Archived-At: Richard Stallman writes: > Without the change in keyboard.c, won't sit_for crash given nil as an > argument? There is a NUMBERP test in both versions. Here is the diff again (in context format) *** keyboard.c 15 Sep 2006 07:19:14 -0000 1.877 --- keyboard.c 10 Oct 2006 01:20:20 -0000 1.878 *************** *** 1546,1560 **** if (minibuf_level && !NILP (echo_area_buffer[0]) ! && EQ (minibuf_window, echo_area_window) ! && NUMBERP (Vminibuffer_message_timeout)) { /* Bind inhibit-quit to t so that C-g gets read in rather than quitting back to the minibuffer. */ int count = SPECPDL_INDEX (); specbind (Qinhibit_quit, Qt); ! sit_for (Vminibuffer_message_timeout, 0, 2); /* Clear the echo area. */ message2 (0, 0, 0); --- 1546,1562 ---- if (minibuf_level && !NILP (echo_area_buffer[0]) ! && EQ (minibuf_window, echo_area_window)) { /* Bind inhibit-quit to t so that C-g gets read in rather than quitting back to the minibuffer. */ int count = SPECPDL_INDEX (); specbind (Qinhibit_quit, Qt); ! if (NUMBERP (Vminibuffer_message_timeout)) ! sit_for (Vminibuffer_message_timeout, 0, 2); ! else ! sit_for (Qt, 0, 2); /* Clear the echo area. */ message2 (0, 0, 0); -- Johan Bockgård