Re: Idle timers with the active minibuffer

[bojohan+news@dd.chalmers.se (Johan Bockgård)]

Richard Stallman <rms@gnu.org> writes:

> Without the change in keyboard.c, won't sit_for crash given nil as an
> argument?

There is a NUMBERP test in both versions. Here is the diff again (in
context format)

*** keyboard.c	15 Sep 2006 07:19:14 -0000	1.877
--- keyboard.c	10 Oct 2006 01:20:20 -0000	1.878
***************
*** 1546,1560 ****
  
        if (minibuf_level
  	  && !NILP (echo_area_buffer[0])
! 	  && EQ (minibuf_window, echo_area_window)
! 	  && NUMBERP (Vminibuffer_message_timeout))
  	{
  	  /* Bind inhibit-quit to t so that C-g gets read in
  	     rather than quitting back to the minibuffer.  */
  	  int count = SPECPDL_INDEX ();
  	  specbind (Qinhibit_quit, Qt);
  
! 	  sit_for (Vminibuffer_message_timeout, 0, 2);
  
  	  /* Clear the echo area.  */
  	  message2 (0, 0, 0);
--- 1546,1562 ----
  
        if (minibuf_level
  	  && !NILP (echo_area_buffer[0])
! 	  && EQ (minibuf_window, echo_area_window))
  	{
  	  /* Bind inhibit-quit to t so that C-g gets read in
  	     rather than quitting back to the minibuffer.  */
  	  int count = SPECPDL_INDEX ();
  	  specbind (Qinhibit_quit, Qt);
  
! 	  if (NUMBERP (Vminibuffer_message_timeout))
! 	    sit_for (Vminibuffer_message_timeout, 0, 2);
! 	  else
! 	    sit_for (Qt, 0, 2);
  
  	  /* Clear the echo area.  */
  	  message2 (0, 0, 0);


-- 
Johan Bockgård