From: bojohan+news@dd.chalmers.se (Johan Bockgård)
To: emacs-devel@gnu.org
Subject: Re: Idle timers with the active minibuffer
Date: Sat, 10 Nov 2007 00:21:55 +0100 [thread overview]
Message-ID: <yoijwssr57jg.fsf@remote4.student.chalmers.se> (raw)
In-Reply-To: E1IqbtX-0003G5-D8@fencepost.gnu.org
Richard Stallman <rms@gnu.org> writes:
> Without the change in keyboard.c, won't sit_for crash given nil as an
> argument?
There is a NUMBERP test in both versions. Here is the diff again (in
context format)
*** keyboard.c 15 Sep 2006 07:19:14 -0000 1.877
--- keyboard.c 10 Oct 2006 01:20:20 -0000 1.878
***************
*** 1546,1560 ****
if (minibuf_level
&& !NILP (echo_area_buffer[0])
! && EQ (minibuf_window, echo_area_window)
! && NUMBERP (Vminibuffer_message_timeout))
{
/* Bind inhibit-quit to t so that C-g gets read in
rather than quitting back to the minibuffer. */
int count = SPECPDL_INDEX ();
specbind (Qinhibit_quit, Qt);
! sit_for (Vminibuffer_message_timeout, 0, 2);
/* Clear the echo area. */
message2 (0, 0, 0);
--- 1546,1562 ----
if (minibuf_level
&& !NILP (echo_area_buffer[0])
! && EQ (minibuf_window, echo_area_window))
{
/* Bind inhibit-quit to t so that C-g gets read in
rather than quitting back to the minibuffer. */
int count = SPECPDL_INDEX ();
specbind (Qinhibit_quit, Qt);
! if (NUMBERP (Vminibuffer_message_timeout))
! sit_for (Vminibuffer_message_timeout, 0, 2);
! else
! sit_for (Qt, 0, 2);
/* Clear the echo area. */
message2 (0, 0, 0);
--
Johan Bockgård
next prev parent reply other threads:[~2007-11-09 23:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 0:42 Idle timers with the active minibuffer Juri Linkov
2007-11-08 13:53 ` Johan Bockgård
2007-11-09 22:00 ` Richard Stallman
2007-11-09 23:21 ` Johan Bockgård [this message]
[not found] ` <E1Isspk-0003bO-Av@fencepost.gnu.org>
2008-02-23 19:46 ` [Emacs 22.2] " Juri Linkov
2008-02-23 21:03 ` Chong Yidong
2007-11-08 17:40 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yoijwssr57jg.fsf@remote4.student.chalmers.se \
--to=bojohan+news@dd.chalmers.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.