From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: bojohan+mail@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=) Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; face-problems with multy-tty Date: Tue, 18 Sep 2007 15:55:36 +0200 Message-ID: References: <87ejhcmgp2.fsf@baldur.tsdh.de> <200709062116.l86LGWnO000262@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1190123809 7391 80.91.229.12 (18 Sep 2007 13:56:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2007 13:56:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 18 15:56:42 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IXdYr-0007S3-5d for ged-emacs-devel@m.gmane.org; Tue, 18 Sep 2007 15:56:21 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IXdYp-0007GJ-O0 for ged-emacs-devel@m.gmane.org; Tue, 18 Sep 2007 09:56:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IXdYn-0007GB-5K for emacs-devel@gnu.org; Tue, 18 Sep 2007 09:56:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IXdYm-0007Fy-GZ for emacs-devel@gnu.org; Tue, 18 Sep 2007 09:56:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IXdYm-0007Fv-AJ for emacs-devel@gnu.org; Tue, 18 Sep 2007 09:56:16 -0400 Original-Received: from anubis.medic.chalmers.se ([129.16.30.218]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IXdYh-0002lZ-II; Tue, 18 Sep 2007 09:56:11 -0400 Original-Received: from gamma02.me.chalmers.se (gamma02.me.chalmers.se [129.16.50.72]) by anubis.medic.chalmers.se (Postfix) with ESMTP id 1A5B6E492; Tue, 18 Sep 2007 15:55:38 +0200 (CEST) Original-Received: by gamma02.me.chalmers.se (Postfix, from userid 61540) id 4DF6A1BCE3C; Tue, 18 Sep 2007 15:55:36 +0200 (CEST) In-Reply-To: (Richard Stallman's message of "Sun, 16 Sep 2007 23:59:15 -0400") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) X-Detected-Kernel: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:79192 Archived-At: Richard Stallman writes: > The old code boiled down to calling `set-face-attribute' with a null > FRAME argument. This sets a new frame default that is the same for all > frames (via face-new-frame-defaults). That is not what we want. > > The new code calls set-face-attribute locally for each frame. It does > not set a default in face-new-frame-defaults. This DTRT unless a defa= ult > exists in face-new-frame-defaults (or an X resource exists for the > face). > > You are basically right. It's just that I think the change you made > really needs to be inside face-spec-set. Ok, I agree. > That way, face-spec-set will DTRT _also_. This still isn't quite the right thing: (set-face-attribute 'font-lock-string-face nil :foreground "yellow") (custom-set-faces '(font-lock-string-face ((((class color) (background light)) (:foreground "red")) (((class color) (background dark)) (:foreground "blue"))))) ;; `C-x 5 2' uses a yellow font-lock-string-face. I think custom-set-faces (and face-spec-set?) should clear the new-frame default. --=20 Johan Bockg=C3=A5rd