From: bojohan+news@dd.chalmers.se (Johan Bockgård)
To: emacs-devel@gnu.org
Subject: Re: Calling occur from within isearch
Date: Wed, 05 Dec 2007 00:59:12 +0100 [thread overview]
Message-ID: <yoij8x4aovu7.fsf@remote1.student.chalmers.se> (raw)
In-Reply-To: 87zlwq3wtw.fsf@jurta.org
Juri Linkov <juri@jurta.org> writes:
>>> saying that the distinction between `yes' and `t' is valid for some
>>> searching interactive commands.
>>
>> I can't see how this distinction is at all useful for the user.
>> `search-uppercase' already provides a (the) way to decide whether "mixed
>> case in the search string [should be] ignored":
>>
>> (if (and case-fold-search search-upper-case)
>> (isearch-no-upper-case-p regexp t)
>> case-fold-search)
>
> I can't comment why isearch functions use `(eq case-fold-search t)',
> but I think other interactive search-related commands like occur
> should use the same condition, whatever it is.
Note that the preceding line is
(let ((case-fold-search isearch-case-fold-search))
and that there are two other places in isearch that use
(and (eq isearch-case-fold-search t) search-upper-case)
Isearch needs the third value `yes' to handle the M-c feature (see
isearch-toggle-case-fold)
C-s ABC M-c => search is now case-insensitive, despite uppercase input
This is the only situation where `yes' is used; case-fold-search never
has this value outside isearch.
Other search functions have no use for this.
>> In the case of occur from within isearch, the current value of
>> isearch-case-fold-search will make searching find the right matches--if
>> occur does *not* look at the case of the input again
>>
>> (let ((case-fold-search isearch-case-fold-search)
>> (search-upper-case nil))
>> (occur regexp nlines))
>
> What code in occur for this case do you have in mind?
isearch-occur should do this. Isearch has already decided if the search
should be case-sensitive or not, so occur should not consider input
case.
--
Johan Bockgård
next prev parent reply other threads:[~2007-12-04 23:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 19:57 Calling occur from within isearch Lennart Borgman (gmail)
2007-11-21 20:03 ` Juri Linkov
2007-11-21 20:25 ` Lennart Borgman (gmail)
2007-11-22 19:08 ` Juri Linkov
2007-11-22 19:38 ` Drew Adams
2007-11-22 21:48 ` Lennart Borgman (gmail)
2007-11-22 0:30 ` Johan Bockgård
2007-11-22 19:04 ` Juri Linkov
2007-11-23 0:52 ` Juri Linkov
2007-11-23 1:05 ` Johan Bockgård
2007-11-24 17:45 ` Juri Linkov
2007-11-25 3:42 ` Richard Stallman
2007-11-25 15:27 ` Juri Linkov
2007-12-03 0:37 ` Juri Linkov
2007-12-03 18:43 ` Richard Stallman
2007-12-05 22:17 ` Juri Linkov
2007-12-06 1:29 ` Johan Bockgård
2007-12-03 23:25 ` Johan Bockgård
2007-12-04 0:27 ` Juri Linkov
2007-12-04 1:24 ` Johan Bockgård
2007-12-04 22:43 ` Juri Linkov
2007-12-04 23:59 ` Johan Bockgård [this message]
2007-12-05 22:16 ` Juri Linkov
2007-12-04 10:35 ` Andreas Schwab
2007-11-21 20:07 ` Drew Adams
2007-11-22 16:21 ` Richard Stallman
2007-11-22 18:16 ` Stefan Monnier
2007-11-22 19:05 ` Juri Linkov
2007-11-22 21:23 ` Stefan Monnier
2007-11-22 19:05 ` Juri Linkov
2007-11-23 4:35 ` Richard Stallman
2007-11-24 17:45 ` Juri Linkov
2007-11-25 3:42 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yoij8x4aovu7.fsf@remote1.student.chalmers.se \
--to=bojohan+news@dd.chalmers.se \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.