From: bojohan+news@dd.chalmers.se (Johan Bockgård)
Subject: Re: [bug] read-passwd of CVS Emacs
Date: Wed, 24 May 2006 23:09:50 +0200 [thread overview]
Message-ID: <yoij4pzf9lk1.fsf@linus003.dd.chalmers.se> (raw)
In-Reply-To: e528n1$agf$1@sea.gmane.org
Kevin Rodgers <ihs_4664@yahoo.com> writes:
> David Kastrup wrote:
>> Kevin Rodgers <ihs_4664@yahoo.com> writes:
>>
>>> Kazu Yamamoto (山本和彦) wrote:
>>>> If the CONFIRM argument is specified to read-passwd of CVS Emacs, it
>>>> causes an error after a user type a first password.
>>>>
>>>> (read-passwd "password: " t)
>>> The error is "Attempt to modify read-only object" and is somehow caused
>>> by a string indexing bug. Here's a patch:
> ...
>> Looks like causing trouble when the prompt is an empty string. And
>> it looks like it would leave the properties off the last character
>> of the prompt. Correct?
>
> You're right on both counts -- thanks for catching that! I should
> have investigated further before posting a patch that has nothing to
> do with the underlying error.
Your latest patch also has nothing to do with it AFAICT. The string is
in pure storage--you need to make a copy.
--
Johan Bockgård
next prev parent reply other threads:[~2006-05-24 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 3:37 [bug] read-passwd of CVS Emacs Kazu Yamamoto
2006-05-24 16:08 ` Kevin Rodgers
2006-05-24 16:35 ` David Kastrup
2006-05-24 18:29 ` Kevin Rodgers
2006-05-24 21:09 ` Johan Bockgård [this message]
2006-05-24 22:08 ` David Kastrup
2006-05-25 0:37 ` Richard Stallman
2006-05-25 16:31 ` Kevin Rodgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yoij4pzf9lk1.fsf@linus003.dd.chalmers.se \
--to=bojohan+news@dd.chalmers.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.