From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Warnings about keymaps Date: Fri, 18 Sep 2009 18:25:27 -0400 Message-ID: References: <83ocph26p7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1253312746 3760 80.91.229.12 (18 Sep 2009 22:25:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Sep 2009 22:25:46 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 19 00:25:39 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Molta-0005cX-M4 for ged-emacs-devel@m.gmane.org; Sat, 19 Sep 2009 00:25:38 +0200 Original-Received: from localhost ([127.0.0.1]:44257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Molta-0003uD-38 for ged-emacs-devel@m.gmane.org; Fri, 18 Sep 2009 18:25:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoltU-0003tM-Kq for emacs-devel@gnu.org; Fri, 18 Sep 2009 18:25:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoltQ-0003rE-4n for emacs-devel@gnu.org; Fri, 18 Sep 2009 18:25:32 -0400 Original-Received: from [199.232.76.173] (port=46347 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoltQ-0003rB-1J for emacs-devel@gnu.org; Fri, 18 Sep 2009 18:25:28 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:58690) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoltP-00022Q-OV for emacs-devel@gnu.org; Fri, 18 Sep 2009 18:25:27 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MoltP-0008G8-9b; Fri, 18 Sep 2009 18:25:27 -0400 X-Spook: FSF CIA BLU-114/B David John Oates ANZUS AFSPC MILSATCOM X-Ran: :@{v_mhTkH}Bqv9>veEU#P8-_45L\DzIAflj`[@{=]gXN:_ List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:115471 Archived-At: Stefan Monnier wrote: > It may seem like a braindead case, but when comparing "broken code > in corner cases" vs "incorrect warning in some cases", I prefer the > incorrect warning. Definitely. >> I think it would be better to change define-derived-mode to not defvar >> the map if it is already defined; > > I don't know how to do that. Oh well, that makes two of us. >> or to change easy-mode-defmap to not use defconst > > That might be an acceptable workaround. But the underlying problem will > still be there. But under a carpet. :) >> (are you saying users should not add key bindings to >> log-edit-mode-map, for example?). > > That's unrelated: defconst only says that the variable's binding won't > change, not that the object it is bound to is immutable. I don't understand that distinction. I just read the doc of defconst: The intent is that neither programs nor users should ever change this value. which seems clear to me.