bug#33629: 27.0.50; Emacs built --without-threads signals (void-function thread-name) when `save-buffers-kill-terminal'

bug#33629: 27.0.50; Emacs built --without-threads signals (void-function thread-name) when `save-buffers-kill-terminal'

[İ. Göktuğ Kayaalp]

Reproduce w/ emacs -Q

M-x shell
M-x toggle-debug-on-error (optionally)
C-x C-c

The stack trace:

Debugger entered--Lisp error: (void-function thread-name)
  (thread-name #<thread 0xc453a0>)
  (list-processes--refresh)
  (list-processes t)
  (save-buffers-kill-emacs nil)
  (save-buffers-kill-terminal nil)
  (funcall-interactively save-buffers-kill-terminal nil)
  (call-interactively save-buffers-kill-terminal nil nil)
  (command-execute save-buffers-kill-terminal)

When I look at `(process-list)' at this moment, it's contents is only

(#<process shell>)

I’ve had this with an earlier build (should be from a couple weeks ago),
I don’t have it around anymore.  I’ll keep my current one around should
you ask me to debug it.

In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-12-04 built on alpha
Repository revision: bc6ffabe803f63e99cfbeab79aa0dbdf77f756cb
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11902000
System Description: Debian GNU/Linux 9 (stretch)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
s-u is undefined

Configured using:
 'configure --prefix=/home/g/local/emacs --with-x-toolkit=athena
 --with-imagemagick --with-modules --with-file-notification=yes
 --with-gameuser=no --with-mailutils --without-threads'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS
GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT
LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES JSON
LCMS2 GMP

Important settings:
  value of $LC_MONETARY: tr_TR.UTF-8
  value of $LC_TIME: tr_TR.UTF-8
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv compile
comint ansi-color ring bytecomp byte-compile cconv dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 102504 8739)
 (symbols 48 20735 1)
 (strings 32 30677 1780)
 (string-bytes 1 823590)
 (vectors 16 15714)
 (vector-slots 8 517374 9188)
 (floats 8 49 247)
 (intervals 56 269 0)
 (buffers 992 13))

-- 
İ. Göktuğ Kayaalp	<https://www.gkayaalp.com/>
			 024C 30DD 597D 142B 49AC
			 40EB 465C D949 B101 2427

bug#33629: 27.0.50; Emacs built --without-threads signals (void-function thread-name) when `save-buffers-kill-terminal'

[Eli Zaretskii]

> From: İ. Göktuğ Kayaalp
> 	<self@gkayaalp.com>
> Date: Wed, 05 Dec 2018 18:37:26 +0300
> 
> 
> Reproduce w/ emacs -Q
> 
> M-x shell
> M-x toggle-debug-on-error (optionally)
> C-x C-c
> 
> The stack trace:
> 
> Debugger entered--Lisp error: (void-function thread-name)
>   (thread-name #<thread 0xc453a0>)
>   (list-processes--refresh)
>   (list-processes t)

Does the patch below fix the problem?

diff --git a/lisp/simple.el b/lisp/simple.el
index e192238..db59b9f 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -4006,7 +4006,9 @@ list-processes--refresh
 		  (tty (or (process-tty-name p) "--"))
 		  (thread
                    (cond
-                    ((null (process-thread p)) "--")
+                    ((or
+                      (null (process-thread p))
+                      (not (fboundp 'thread-name))) "--")
                     ((eq (process-thread p) main-thread) "Main")
                     ((thread-name (process-thread p)))))
 		  (cmd

bug#33629: 27.0.50; Emacs built --without-threads signals (void-function thread-name) when `save-buffers-kill-terminal'

[Göktuğ Kayaalp]

On 2018-12-05 20:21 +02, Eli Zaretskii <eliz@gnu.org> wrote:
> Does the patch below fix the problem?

Yes, thank you!

> diff --git a/lisp/simple.el b/lisp/simple.el
> index e192238..db59b9f 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -4006,7 +4006,9 @@ list-processes--refresh
>  		  (tty (or (process-tty-name p) "--"))
>  		  (thread
>                     (cond
> -                    ((null (process-thread p)) "--")
> +                    ((or
> +                      (null (process-thread p))
> +                      (not (fboundp 'thread-name))) "--")
>                      ((eq (process-thread p) main-thread) "Main")
>                      ((thread-name (process-thread p)))))
>  		  (cmd


-- 
İ. Göktuğ Kayaalp	<https://www.gkayaalp.com/>
			 024C 30DD 597D 142B 49AC
			 40EB 465C D949 B101 2427

bug#33629: 27.0.50; Emacs built --without-threads signals (void-function thread-name) when `save-buffers-kill-terminal'

[Eli Zaretskii]

> From: Göktuğ Kayaalp <self@gkayaalp.com>
> Cc: 33629@debbugs.gnu.org
> Date: Thu, 06 Dec 2018 16:57:21 +0300
> 
> On 2018-12-05 20:21 +02, Eli Zaretskii <eliz@gnu.org> wrote:
> > Does the patch below fix the problem?
> 
> Yes, thank you!

Thanks, pushed.