From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?G=C3=B6ktu=C4=9F?= Kayaalp Newsgroups: gmane.emacs.bugs Subject: bug#28570: 27.0.50; [PATCH] Disable unhelpful default Extra: header in vc-dir Date: Sat, 23 Sep 2017 18:39:50 +0300 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1506181274 32193 195.159.176.226 (23 Sep 2017 15:41:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 23 Sep 2017 15:41:14 +0000 (UTC) To: 28570@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 23 17:41:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvmYC-0007o1-NH for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 17:41:04 +0200 Original-Received: from localhost ([::1]:35284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvmYJ-0006d1-UN for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Sep 2017 11:41:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvmYD-0006cv-Bx for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 11:41:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvmYA-0006W8-7w for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 11:41:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46060) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvmYA-0006W2-3X for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 11:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dvmY9-0006RI-R8 for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 11:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?G=C3=B6ktu=C4=9F?= Kayaalp Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Sep 2017 15:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28570 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150618120824683 (code B ref -1); Sat, 23 Sep 2017 15:41:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Sep 2017 15:40:08 +0000 Original-Received: from localhost ([127.0.0.1]:54741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvmXI-0006Q3-9A for submit@debbugs.gnu.org; Sat, 23 Sep 2017 11:40:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvmXG-0006PV-Q7 for submit@debbugs.gnu.org; Sat, 23 Sep 2017 11:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvmX9-00069Z-U4 for submit@debbugs.gnu.org; Sat, 23 Sep 2017 11:40:01 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:38203) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvmX9-00069Q-Qo for submit@debbugs.gnu.org; Sat, 23 Sep 2017 11:39:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvmX8-0006DA-5o for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 11:39:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvmX5-00067x-28 for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 11:39:58 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:59754) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvmX4-00064f-Ml for bug-gnu-emacs@gnu.org; Sat, 23 Sep 2017 11:39:54 -0400 X-Originating-IP: 46.2.224.253 Original-Received: from alpha.alpha (unknown [46.2.224.253]) (Authenticated sender: self@gkayaalp.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 83C3EA80C2 for ; Sat, 23 Sep 2017 17:39:51 +0200 (CEST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137297 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable The function =E2=80=98vc-default-dir-extra-headers=E2=80=99 is implemented = as a stub function that prints in the vc-dir buffer a rather annoying and unhelpful message advicing that the implementer of a VC backend should create some backend specific headers and that doing this is easy. vc-rcs doesn't implement any (and I doubt it needs), and thus whenever I use vc-dir on an RCS repository, this message is shown. Attached is a patch that disables this behaviour by making the said function return nil instead (the function as it is includes a comment that says to do so before the =E2=80=98release=E2=80=99). --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=vc-default-dir-extra-headers.patch Content-Description: the patch diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el index 41c44e2c24..839f401153 100644 --- a/lisp/vc/vc-dir.el +++ b/lisp/vc/vc-dir.el @@ -1275,13 +1275,8 @@ vc-dir (vc-dir-mode)))) (defun vc-default-dir-extra-headers (_backend _dir) - ;; Be loud by default to remind people to add code to display - ;; backend specific headers. - ;; XXX: change this to return nil before the release. - (concat - (propertize "Extra : " 'face 'font-lock-type-face) - (propertize "Please add backend specific headers here. It's easy!" - 'face 'font-lock-warning-face))) + (ignore _backend _dir) + nil) (defvar vc-dir-filename-mouse-map (let ((map (make-sparse-keymap))) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-09-23 built on alpha Repository revision: c0af83b6ccf2dab9a515dd7f52eb9d4500275ae3 Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Ubuntu 17.04 Recent messages: user-error: Beginning of history; no preceding item Making completion list... [2 times] You can run the command =E2=80=98eval-buffer=E2=80=99 with M-x ev-b RET Please type y, n, or !: n [2 times] Traversing directory /igk/documents/not/org/... Traversing directory /igk/documents/not/org/Attic... Traversing directory /igk/documents/not/org/Attic/old_rcs... Traversing directory /igk/documents/not/org/img... Traversing directory /igk/documents/not/org/mobile... Traversing directory /igk/documents/not/org/...done Configured using: 'configure --prefix=3D/home/g/local --with-x-toolkit=3Dgtk3 --with-modules --with-file-notification=3Dyes --without-threads --with-gameuser=3Dno --with-mailutils' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES LCMS2 Important settings: value of $LC_MESSAGES: en_GB.UTF-8 value of $LC_MONETARY: tr_TR.UTF-8 value of $LC_NUMERIC: tr_TR.UTF-8 value of $LC_TIME: tr_TR.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny format-spec rfc822 mml mml-sec password-cache epa epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-filewise vc-rcs dired dired-loaddefs vc-dir derived edmacro kmacro cl-seq cl-macs ewoc vc vc-dispatcher vc-git diff-mode easymenu easy-mmode map seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 112482 13582) (symbols 48 21631 1) (miscs 40 59 266) (strings 32 32386 1218) (string-bytes 1 844152) (vectors 16 16604) (vector-slots 8 510732 9057) (floats 8 52 204) (intervals 56 513 29) (buffers 992 18)) --=20 =C4=B0. G=C3=B6ktu=C4=9F Kayaalp http://www.gkayaalp.com/index= .html self@gkayaalp.com =F0=9F=8E=80 PGP =3D 024C 30DD 597D 142B 49= AC Plaintext please! {UTF8} Fingerprint 40EB 465C D949 B101 2427 --=-=-=--