bug#28570: 27.0.50; [PATCH] Disable unhelpful default Extra: header in vc-dir

["Göktuğ Kayaalp" <self@gkayaalp.com>]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]


The function ‘vc-default-dir-extra-headers’ is implemented as a stub
function that prints in the vc-dir buffer a rather annoying and
unhelpful message advicing that the implementer of a VC backend should
create some backend specific headers and that doing this is easy.
vc-rcs doesn't implement any (and I doubt it needs), and thus whenever I
use vc-dir on an RCS repository, this message is shown.  Attached is a
patch that disables this behaviour by making the said function return
nil instead (the function as it is includes a comment that says to do so
before the ‘release’).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: the patch --]
[-- Type: text/x-diff, Size: 692 bytes --]

diff --git a/lisp/vc/vc-dir.el b/lisp/vc/vc-dir.el
index 41c44e2c24..839f401153 100644
--- a/lisp/vc/vc-dir.el
+++ b/lisp/vc/vc-dir.el
@@ -1275,13 +1275,8 @@ vc-dir
       (vc-dir-mode))))
 
 (defun vc-default-dir-extra-headers (_backend _dir)
-  ;; Be loud by default to remind people to add code to display
-  ;; backend specific headers.
-  ;; XXX: change this to return nil before the release.
-  (concat
-   (propertize "Extra      : " 'face 'font-lock-type-face)
-   (propertize "Please add backend specific headers here.  It's easy!"
-	       'face 'font-lock-warning-face)))
+  (ignore _backend _dir)
+  nil)
 
 (defvar vc-dir-filename-mouse-map
    (let ((map (make-sparse-keymap)))

[-- Attachment #3: Type: text/plain, Size: 4016 bytes --]



In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-09-23 built on alpha
Repository revision: c0af83b6ccf2dab9a515dd7f52eb9d4500275ae3
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description:	Ubuntu 17.04

Recent messages:
user-error: Beginning of history; no preceding item
Making completion list... [2 times]
You can run the command ‘eval-buffer’ with M-x ev-b RET
Please type y, n, or !: n [2 times]
Traversing directory /igk/documents/not/org/...
Traversing directory /igk/documents/not/org/Attic...
Traversing directory /igk/documents/not/org/Attic/old_rcs...
Traversing directory /igk/documents/not/org/img...
Traversing directory /igk/documents/not/org/mobile...
Traversing directory /igk/documents/not/org/...done

Configured using:
 'configure --prefix=/home/g/local --with-x-toolkit=gtk3 --with-modules
 --with-file-notification=yes --without-threads --with-gameuser=no
 --with-mailutils'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES LCMS2

Important settings:
  value of $LC_MESSAGES: en_GB.UTF-8
  value of $LC_MONETARY: tr_TR.UTF-8
  value of $LC_NUMERIC: tr_TR.UTF-8
  value of $LC_TIME: tr_TR.UTF-8
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  diff-auto-refine-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny format-spec rfc822
mml mml-sec password-cache epa epg epg-config gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils vc-filewise vc-rcs dired dired-loaddefs
vc-dir derived edmacro kmacro cl-seq cl-macs ewoc vc vc-dispatcher
vc-git diff-mode easymenu easy-mmode map seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib elec-pair time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 112482 13582)
 (symbols 48 21631 1)
 (miscs 40 59 266)
 (strings 32 32386 1218)
 (string-bytes 1 844152)
 (vectors 16 16604)
 (vector-slots 8 510732 9057)
 (floats 8 52 204)
 (intervals 56 513 29)
 (buffers 992 18))

-- 
İ. Göktuğ Kayaalp              http://www.gkayaalp.com/index.html
self@gkayaalp.com    🎀            PGP = 024C 30DD 597D 142B 49AC
Plaintext please!  {UTF8}  Fingerprint   40EB 465C D949 B101 2427