From: Glenn Morris <rgm@gnu.org>
To: 8647@debbugs.gnu.org
Subject: bug#8647: since lexical merge, declare-function in subr.el no longer works
Date: Wed, 11 May 2011 14:12:48 -0400 [thread overview]
Message-ID: <ygaaetxg0v.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <bmzkmu8a0v.fsf@fencepost.gnu.org>
Moving the definition to the end of subr.el does not work, because
subr.el is loaded uncompiled during bootstrap.
IMO, conceptually the right fix is for an element in
byte-compile-initial-macro-environment to _always_ take precedence
during compilation, even if the file being compiled contains a
redefinition.
*** lisp/emacs-lisp/bytecomp.el 2011-05-11 17:32:38 +0000
--- lisp/emacs-lisp/bytecomp.el 2011-05-11 17:57:12 +0000
***************
*** 2166,2172 ****
byte-compile-output nil))))
(defun byte-compile-preprocess (form &optional _for-effect)
! (setq form (macroexpand-all form byte-compile-macro-environment))
;; FIXME: We should run byte-optimize-form here, but it currently does not
;; recurse through all the code, so we'd have to fix this first.
;; Maybe a good fix would be to merge byte-optimize-form into
--- 2174,2183 ----
byte-compile-output nil))))
(defun byte-compile-preprocess (form &optional _for-effect)
! ;; b-c-initial-m-e should take precedence during compilation. (Bug#8647)
! (setq form (macroexpand-all form
! (append byte-compile-initial-macro-environment
! byte-compile-macro-environment)))
;; FIXME: We should run byte-optimize-form here, but it currently does not
;; recurse through all the code, so we'd have to fix this first.
;; Maybe a good fix would be to merge byte-optimize-form into
next prev parent reply other threads:[~2011-05-11 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 22:29 bug#8647: since lexical merge, declare-function in subr.el no longer works Glenn Morris
2011-05-11 18:12 ` Glenn Morris [this message]
2011-05-12 1:02 ` Stefan Monnier
2011-05-12 2:36 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ygaaetxg0v.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=8647@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.