From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Koppelman Newsgroups: gmane.emacs.devel Subject: Re: Yanking isearch to highlight-regexp Date: Mon, 16 Jun 2008 13:50:58 -0500 Message-ID: References: <4853F884.7000609@gmail.com> <7dbe73ed0806141442h342f8ff0u83863f3980a7e229@mail.gmail.com> <48545D78.8080103@gmail.com> <4854E536.8040407@gmail.com> <87k5gql900.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213642360 29483 80.91.229.12 (16 Jun 2008 18:52:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Jun 2008 18:52:40 +0000 (UTC) Cc: "Lennart Borgman \(gmail\)" , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 16 20:53:23 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K8JpC-00072d-8E for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 20:53:06 +0200 Original-Received: from localhost ([127.0.0.1]:36123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8JoN-0001dz-Sa for ged-emacs-devel@m.gmane.org; Mon, 16 Jun 2008 14:52:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8JnH-0000zY-1h for emacs-devel@gnu.org; Mon, 16 Jun 2008 14:51:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K8JnF-0000xr-Ap for emacs-devel@gnu.org; Mon, 16 Jun 2008 14:51:06 -0400 Original-Received: from [199.232.76.173] (port=44296 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8JnF-0000xj-4m for emacs-devel@gnu.org; Mon, 16 Jun 2008 14:51:05 -0400 Original-Received: from ecelsrv1.ece.lsu.edu ([130.39.223.98]:50384) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K8JnE-0000Re-QK for emacs-devel@gnu.org; Mon, 16 Jun 2008 14:51:04 -0400 Original-Received: from localhost (unknown [127.0.0.1]) by ecelsrv1.ece.lsu.edu (Postfix) with ESMTP id 58509280D9; Mon, 16 Jun 2008 18:51:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at ece.lsu.edu Original-Received: from ecelsrv1.ece.lsu.edu ([127.0.0.1]) by localhost (ecelsrv1.ece.lsu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KYryVLnzL1kr; Mon, 16 Jun 2008 13:50:58 -0500 (CDT) Original-Received: from nested.ece.lsu.edu (nested.ece.lsu.edu [130.39.222.143]) by ecelsrv1.ece.lsu.edu (Postfix) with ESMTP id C1F5228018; Mon, 16 Jun 2008 13:50:58 -0500 (CDT) In-Reply-To: <87k5gql900.fsf@jurta.org> (Juri Linkov's message of "Sun, 15 Jun 2008 23:48:47 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99312 Archived-At: I like the idea of combining regexp histories, but we might want to be careful. I can see sharing patterns between hi-lock and occur because they are used for locating things, but isearch patterns are used for navigation and so might contain many regexps matching little pieces of text that only occasionally would make good highlight targets. I'd suggest having a shared history for occur and hi-lock with a few recent isearch targets mixed in. Juri Linkov writes: > As for the separate case of running `highlight-regexp' after isearch is > finished, I suggest using the same default values as already provided by > `occur-read-primary-args' and `keep-lines-read-args' that collect a list > of useful regexps from different places including the last isearch string > and put them to the list of default values. > > This also suggests to get rid of `hi-lock-regexp-history' in favor of > the single regexp history variable `regexp-history' shared among all > regexp-reading commands (perhaps `keep-lines-read-args' should be > renamed to more general name like `read-regexp'). >