From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Ernest N. Mamikonyan" Newsgroups: gmane.emacs.bugs Subject: bug#40001: tex-start-options-string not updated in texinfo.el Date: Fri, 13 Mar 2020 10:37:17 -0400 Organization: Susquehanna International Group, LLP Message-ID: References: <83h7ys8iod.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="37479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) Cc: 40001@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 13 15:46:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jClZv-0009dG-PI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Mar 2020 15:46:23 +0100 Original-Received: from localhost ([::1]:60298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jClZu-0002MA-QM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 Mar 2020 10:46:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40203) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jClZd-0002JI-5L for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 10:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jClZb-0001C8-BI for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 10:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54157) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jClZa-0001BV-KS for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 10:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jClZa-0005QK-Hg for bug-gnu-emacs@gnu.org; Fri, 13 Mar 2020 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Ernest N. Mamikonyan" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Mar 2020 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40001 X-GNU-PR-Package: emacs Original-Received: via spool by 40001-submit@debbugs.gnu.org id=B40001.158411076120839 (code B ref 40001); Fri, 13 Mar 2020 14:46:02 +0000 Original-Received: (at 40001) by debbugs.gnu.org; 13 Mar 2020 14:46:01 +0000 Original-Received: from localhost ([127.0.0.1]:60130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jClZY-0005Q2-Gf for submit@debbugs.gnu.org; Fri, 13 Mar 2020 10:46:00 -0400 Original-Received: from mail1.sig.com ([141.162.101.25]:1963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jClR9-0005Cg-0E for 40001@debbugs.gnu.org; Fri, 13 Mar 2020 10:37:19 -0400 X-SIG-Detect: None X-IronPort-AV: E=Sophos;i="5.70,548,1574139600"; d="scan'208";a="94226297" In-Reply-To: <83h7ys8iod.fsf@gnu.org> X-Mailman-Approved-At: Fri, 13 Mar 2020 10:45:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177278 Archived-At: On Fri, Mar 13 2020, Eli Zaretskii wrote: >> From: "Ernest N. Mamikonyan" >> Date: Mon, 09 Mar 2020 13:26:44 -0400 >> >> It seems that 'tex-start-options-string' was not updated to >> 'tex-start-options' in texinfo.el after the change in version 22. >> >> diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el >> index 438cb7798a..3898a3ba04 100644 >> --- a/lisp/textmodes/texinfo.el >> +++ b/lisp/textmodes/texinfo.el >> @@ -1002,9 +1002,9 @@ texinfo-tex-buffer >> (interactive) >> (require 'tex-mode) >> (let ((tex-command texinfo-texi2dvi-command) >> - ;; Disable tex-start-options-string. texi2dvi would not >> - ;; understand anything specified here. >> - (tex-start-options-string "")) >> + ;; Disable tex-start-options. texi2dvi would not understand >> + ;; anything specified here. >> + (tex-start-options "")) >> (tex-buffer))) > > Should we also bind tex-start-commands to some value (an empty > string)? If not, why not? Yes, you're right. Since texi2dvi doesn't take initial commands like TeX, why not get rid of tex-start-commands but allow the user to supply command-line options: diff --git a/lisp/textmodes/texinfo.el b/lisp/textmodes/texinfo.el index 438cb7798a..a687a27e36 100644 --- a/lisp/textmodes/texinfo.el +++ b/lisp/textmodes/texinfo.el @@ -958,6 +958,11 @@ texinfo-texi2dvi-command :type 'string :group 'texinfo) +(defcustom texinfo-texi2dvi-options "" + "Command line options for `texinfo-texi2dvi-command'." + :type 'string + :group 'texinfo) + (defcustom texinfo-tex-command "tex" "Command used by `texinfo-tex-region' to run TeX on a region." :type 'string @@ -1002,9 +1007,10 @@ texinfo-tex-buffer (interactive) (require 'tex-mode) (let ((tex-command texinfo-texi2dvi-command) - ;; Disable tex-start-options-string. texi2dvi would not - ;; understand anything specified here. - (tex-start-options-string "")) + (tex-start-options texinfo-texi2dvi-options) + ;; Disable tex-start-commands. texi2dvi would not understand + ;; anything specified here. + (tex-start-commands "")) (tex-buffer))) (defun texinfo-texindex () -- Ernie