* Re: Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution. [not found] ` <E1Izb3W-000499-GT@fencepost.gnu.org> @ 2007-12-05 3:33 ` Martin Blais 2007-12-05 13:31 ` Vinicius Jose Latorre ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Martin Blais @ 2007-12-05 3:33 UTC (permalink / raw) To: emacs-devel Hi gang Following up on an old request and comments from RMS, I've recently made ReStructuredText support for emacs (rst.el, which provides rst-mode) to be up-to-snuff for tentative inclusion in GNU Emacs. You can find the latest version here: http://svn.berlios.de/svnroot/repos/docutils/trunk/docutils/tools/editors/emacs/rst.el Full HTML documentation here: http://docutils.sourceforge.net/docs/user/emacs.html For more about ReST, see http://docutils.sf.net/rst.html Any comments? What's the next step? Thanks. cheers, On Tue, 04 Dec 2007 11:55:34 -0500, "Richard Stallman" <rms@gnu.org> said: > The next thing to do is ask emacs-devel to look at it > and comment. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution. 2007-12-05 3:33 ` Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution Martin Blais @ 2007-12-05 13:31 ` Vinicius Jose Latorre 2007-12-18 1:23 ` Glenn Morris 2008-02-08 9:29 ` Leo 2 siblings, 0 replies; 5+ messages in thread From: Vinicius Jose Latorre @ 2007-12-05 13:31 UTC (permalink / raw) To: Martin Blais; +Cc: emacs-devel Martin Blais wrote: > Hi gang > > Following up on an old request and comments from RMS, I've recently made > ReStructuredText support for emacs (rst.el, which provides rst-mode) to > be up-to-snuff for tentative inclusion in GNU Emacs. > > You can find the latest version here: > http://svn.berlios.de/svnroot/repos/docutils/trunk/docutils/tools/editors/emacs/rst.el > > Full HTML documentation here: > http://docutils.sourceforge.net/docs/user/emacs.html > > For more about ReST, see > http://docutils.sf.net/rst.html > > Any comments? > What's the next step? > > Thanks. > cheers, > > > > > On Tue, 04 Dec 2007 11:55:34 -0500, "Richard Stallman" <rms@gnu.org> > said: > >> The next thing to do is ask emacs-devel to look at it >> and comment. >> It seems to be a good package. Is it easy to adapt rst.el to other languages (Perl, ELisp, C/C++, Java, Haskell, etc.)? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution. 2007-12-05 3:33 ` Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution Martin Blais 2007-12-05 13:31 ` Vinicius Jose Latorre @ 2007-12-18 1:23 ` Glenn Morris 2008-02-08 5:21 ` Glenn Morris 2008-02-08 9:29 ` Leo 2 siblings, 1 reply; 5+ messages in thread From: Glenn Morris @ 2007-12-18 1:23 UTC (permalink / raw) To: Martin Blais; +Cc: emacs-devel "Martin Blais" wrote: > http://svn.berlios.de/svnroot/repos/docutils/trunk/docutils/tools/editors/emacs/rst.el [...] > Any comments? I know nothing about ReStructuredText, but the code looks basically ok. Don't define functions with generic names like `filter' and `line-number-at-pos'. Instead, define `rst-filter' etc that do what you want. Since jit-lock has been around since Emacs 21, the messing with font-lock-support in rst-mode is unnecessary. `rst-mode-lazy' seems like a poor name for what the variable does (toggle extra highlighting), and again given that jit lock has been around since Emacs 21 it could probably just be dumped. I'd put the defcustoms and defgroup all together at the start of the file, so people can easily see what can be customized. The :types of defcustoms should just be 'hook, etc, not '(hook), AFAIK. You need (eval-when-compile (require 'cl)) for flet to work, but couldn't you just define an actual function rst-addnum? You need to get rid of `position' in rst-straighten-decorations, since it's a CL function which should not be called at runtime. Byte compiling reveals some free variables, all (?) caused by things being defined after they are used: rst-toc-insert-max-level, rst-toc-buffer-name, rst-toc-return-buffer, rst-level-face-max, rst-level-face-format-light, rst-level-face-base-color, rst-level-face-step-light, rst-level-face-base-light In rst-replace-lines, p and l should be let-bound. Why isn't rst-portable-mark-active-p just checking `mark-active' in the Emacs case? Like all functions, the definition should be moved before its first use. > What's the next step? For all the copyright holders to be willing to sign assignments. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution. 2007-12-18 1:23 ` Glenn Morris @ 2008-02-08 5:21 ` Glenn Morris 0 siblings, 0 replies; 5+ messages in thread From: Glenn Morris @ 2008-02-08 5:21 UTC (permalink / raw) To: Martin Blais; +Cc: emacs-devel Is anything happening with this? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution. 2007-12-05 3:33 ` Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution Martin Blais 2007-12-05 13:31 ` Vinicius Jose Latorre 2007-12-18 1:23 ` Glenn Morris @ 2008-02-08 9:29 ` Leo 2 siblings, 0 replies; 5+ messages in thread From: Leo @ 2008-02-08 9:29 UTC (permalink / raw) To: Martin Blais; +Cc: emacs-devel On 2007-12-05 03:33 +0000, Martin Blais wrote: > You can find the latest version here: > http://svn.berlios.de/svnroot/repos/docutils/trunk/docutils/tools/editors/emacs/rst.el I tried to compile this file and get quite a few warnings: ,---- | In rst-toc-insert: | rst.el:1721:45:Warning: reference to free variable `rst-toc-insert-max-level' | | In rst-toc: | rst.el:1982:34:Warning: reference to free variable `rst-toc-buffer-name' | rst.el:2002:55:Warning: assignment to free variable `rst-toc-return-buffer' | | In rst-define-level-faces: | rst.el:2656:18:Warning: reference to free variable `rst-level-face-max' | rst.el:2659:39:Warning: reference to free variable | `rst-level-face-format-light' | rst.el:2660:26:Warning: reference to free variable `rst-level-face-base-color' | rst.el:2661:39:Warning: reference to free variable `rst-level-face-step-light' | rst.el:2662:29:Warning: reference to free variable `rst-level-face-base-light' | | In rst-replace-lines: | rst.el:3343:19:Warning: assignment to free variable `p' | rst.el:3345:24:Warning: reference to free variable `p' | rst.el:3347:33:Warning: assignment to free variable `l' | rst.el:3347:26:Warning: reference to free variable `l' | | In end of data: | rst.el:3423:1:Warning: the function `filter' is not known to be defined. `---- Bye, -- .: Leo :. [ sdl.web AT gmail.com ] .: [ GPG Key: 9283AA3F ] :. Use the best OS -- http://www.fedoraproject.org/ ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-02-08 9:29 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <1196713877.17873.1224586299@webmail.messagingengine.com> [not found] ` <E1Izb3W-000499-GT@fencepost.gnu.org> 2007-12-05 3:33 ` Fwd: Revamp of rst.el for inclusion in GNU Emacs distribution Martin Blais 2007-12-05 13:31 ` Vinicius Jose Latorre 2007-12-18 1:23 ` Glenn Morris 2008-02-08 5:21 ` Glenn Morris 2008-02-08 9:29 ` Leo
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.