From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#2333: 23.0.90; rmail: rmail-summary-by-topic is not reliable Date: Wed, 18 Feb 2009 16:56:18 -0500 Message-ID: References: <200902142325.n1ENP3s3027009@zogzog.maillard.mobi> Reply-To: Glenn Morris , 2333@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1234994726 19017 80.91.229.12 (18 Feb 2009 22:05:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Feb 2009 22:05:26 +0000 (UTC) Cc: 2333@emacsbugs.donarmstrong.com To: Xavier Maillard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 18 23:06:41 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LZuYx-0003QD-WA for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2009 23:06:40 +0100 Original-Received: from localhost ([127.0.0.1]:59144 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZuXd-0006R0-Sq for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2009 17:05:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LZuW5-0005sV-4u for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 17:03:41 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LZuW4-0005rT-24 for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 17:03:40 -0500 Original-Received: from [199.232.76.173] (port=58034 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZuW3-0005r4-JS for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 17:03:39 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:33725) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LZuW2-0002i3-SC for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 17:03:39 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1IM3ZIN003275; Wed, 18 Feb 2009 14:03:36 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1IM04lZ002019; Wed, 18 Feb 2009 14:00:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Glenn Morris Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , Rmail Maintainers Resent-Date: Wed, 18 Feb 2009 22:00:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2333 X-Emacs-PR-Package: emacs,rmail X-Emacs-PR-Keywords: Original-Received: via spool by 2333-submit@emacsbugs.donarmstrong.com id=B2333.12349943091742 (code B ref 2333); Wed, 18 Feb 2009 22:00:04 +0000 Original-Received: (at 2333) by emacsbugs.donarmstrong.com; 18 Feb 2009 21:58:29 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1ILwQB4001736 for <2333@emacsbugs.donarmstrong.com>; Wed, 18 Feb 2009 13:58:27 -0800 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LZuOw-0003Mi-IX; Wed, 18 Feb 2009 16:56:18 -0500 X-Spook: BLU-97 A/B defense information warfare Verisign BROMURE X-Ran: 8WeOk#^ma./.r;]C!W-d5`,\Z1-;)OS\l;=qfD#`jF1v7!8>r~X`E4'%eh-0&.nD&p5}W# X-Hue: magenta X-Attribution: GM In-Reply-To: <200902142325.n1ENP3s3027009@zogzog.maillard.mobi> (Xavier Maillard's message of "Sun, 15 Feb 2009 00:25:03 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 18 Feb 2009 17:03:40 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25426 Archived-At: Xavier Maillard wrote: > 7840D 3-Feb admin@flosoft.biz [114] { summit } Re: [Summit] Prepaid cellphones [...] > Doing C-M-t RET -i.e. choosing default subject as the topic returns: > No previous message. More generally, rmail-summary-by-topic is > rather unreliable since less than 50% of the time it will return > correct results. One problem is that rmail-summary-by-topic does not regexp-quote the default expression to search for. This leads to the confusing result that you can fail to find the current message, if the subject happens to contain regexp special characters, eg "[ ]" in your example. The patch for that is trivial, and seems like the right thing to do. The "no previous message" message indicates that more care needs to be taken somewhere when there are no matches. *** rmailsum.el 15 Feb 2009 02:52:16 -0000 1.170 --- rmailsum.el 18 Feb 2009 21:55:17 -0000 *************** *** 155,161 **** look in the whole message. SUBJECT is a string of regexps separated by commas." (interactive ! (let* ((subject (rmail-simplified-subject)) (prompt (concat "Topics to summarize by (regexp" (if subject ", default current subject" "") "): "))) --- 155,161 ---- look in the whole message. SUBJECT is a string of regexps separated by commas." (interactive ! (let* ((subject (regexp-quote (rmail-simplified-subject))) (prompt (concat "Topics to summarize by (regexp" (if subject ", default current subject" "") "): ")))