From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: =?iso-8859-1?q?Andreas_B=FCsching?= Newsgroups: gmane.emacs.devel Subject: Re: extensions for emacsclient (CVS version) Date: Wed, 10 Sep 2003 17:02:16 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1063206577 18210 80.91.224.253 (10 Sep 2003 15:09:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 10 Sep 2003 15:09:37 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Sep 10 17:09:35 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19x6b9-0006nr-00 for ; Wed, 10 Sep 2003 17:09:35 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19x6bZ-0002Ou-00 for ; Wed, 10 Sep 2003 17:10:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.22) id 19x6ak-0004is-KN for emacs-devel@quimby.gnus.org; Wed, 10 Sep 2003 11:09:10 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.22) id 19x6WQ-0002Py-8U for emacs-devel@gnu.org; Wed, 10 Sep 2003 11:04:42 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.22) id 19x6Vr-000248-Jm for emacs-devel@gnu.org; Wed, 10 Sep 2003 11:04:08 -0400 Original-Received: from [134.102.224.4] (helo=imh.informatik.uni-bremen.de) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.22) id 19x6UF-00016w-Bn; Wed, 10 Sep 2003 11:02:27 -0400 Original-Received: from dataman.informatik.uni-bremen.de (IDENT:/V6ynbtXp4VuzmAfW2n2q7gE1a/+HFn+@dataman.informatik.uni-bremen.de [134.102.218.127]) by imh.informatik.uni-bremen.de (8.12.9/8.12.9) with ESMTP id h8AF2He0028332; Wed, 10 Sep 2003 17:02:17 +0200 (MEST) Original-Received: (from crunchy@localhost) by dataman.informatik.uni-bremen.de (8.11.6/8.8.7) id h8AF2Gs22056; Wed, 10 Sep 2003 17:02:16 +0200 Original-To: "Stefan Monnier" Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAALVBMVEUAAADgvEcRDgkCAAD4 +PjoxUn//+35+PFNQyz////+/vTCnz7l3sqEckP39eyvu3nmAAACRUlEQVR4nG3UQWsTQRQA4Efi IaI5zGGkkFbC5LJgAmFzyaG9LfVSA3uYk3oQNNDaY88STQ8pxmuwaXoV4kHYniqTQBNCSHUicSNi 2Y4nQYU0v8Hdmc2aZrOn2fnmzZt5+1g4DJ4hAPwM3iAYNZIAeuZjGLpuQN4+CMPIg1fxvyFw5yEH 0fMwRAAIQBgilaQuyBLI81Ka23ARgg0xrlb/wM0Q6JlToQ+WQLySYGQZ2K8xbtvZMAwsStHKcjAT J9lbIeh+pQ47zWghGK4x1hpopYtFEB3B+AuA6gIcb0w6/JcxgvUFGO0X+G/D6M7KOINGqWd4zxXA wTV4G5PzxgOAe9egFO8ZU6PAeSqrCuxDI5mRW3FeTqly+XAcqaqtJmc6xOfginxTYHCSjM1BV/Pn jS1CIudzkA4gpcnsPkRvGEZByUg1qoIjsv8fdLgdwInm5t7ygczByIMlEfUx6fkR96cjkg2gJuwZ FKbjVGx9Bh/o4/Segk1UzunppoL6rkXtLyrHplnOkda2hFoxgeiatqfuh+xcZlXBLmMYJ1KXqohm +42FdjyoP0EII2TnZd0nFmMW7m978AxRatEVXQFzl+FHOzICu0JRRcLQQd5bv6kAUYzuPvU+ue1g E2N6RwIyselu4IGtux2MqelF1DpuborNdovzs2jecsPNVZnjs3cOarbdPwNE8wyZiBab8h5Dx5WE D4573r68x2G9+PyhYExUvHauOKz9vekX8X2xaAlx2ZQNJoT4NNcl7/iPvhzUBy+5XPEPHY0ktsnr +9wAAAAASUVORK5CYII= X-URL: http://www.crunchy-home.de/ In-Reply-To: (Stefan Monnier's message of "10 Sep 2003 10:41:28 -0400") User-Agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:16272 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:16272 "Stefan Monnier" wrote: > [ Please pass the -b option to diff for patches that are ment to be read > by humans. ] > >> + else >> + { >> + while ((str = fgets (string, BUFSIZ, stdin))) >> + { >> + fprintf (out, "%s ", quote_file_name (str)); >> + } > > Have you tested it to see if it works with a large multiline > (and with long lines) stdin ? > I think the space after %s might pose problems (if the input line > is long and is cut in the middle of a symbol for example). > I suggest to use just "%s" instead. D'oh! I just tested it with a short expression, so you are right. I will fix this. > Other than that, it looks fine to me. In order to be able to install > this change in Emacs-CVS, we need to make sure you have signed the relevant > paperwork (ideally an assignment of copyright covering all your changes to > Emacs, IIRC you want to ask assign@gnu.org to get the relevant form). I guess there is no easier way to contribute to the emacs project? crunchy -- "We're back to the times when men were men and wrote their own device drivers" -- Linus Torvalds