From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Sat, 18 Feb 2023 21:56:16 +0000 Message-ID: References: <20230218.061335.1468428093197134401.tats%nobody@tats.iris.ne.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2212"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, spwhitton@spwhitton.name, 1021842@bugs.debian.org To: Tatsuya Kinoshita Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 18 22:56:51 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTVCM-0000Ny-37 for ged-emacs-devel@m.gmane-mx.org; Sat, 18 Feb 2023 22:56:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTVBz-0000pl-Gq; Sat, 18 Feb 2023 16:56:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTVBx-0000my-5g for emacs-devel@gnu.org; Sat, 18 Feb 2023 16:56:25 -0500 Original-Received: from ma.sdf.org ([205.166.94.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTVBv-0004Tt-Io for emacs-devel@gnu.org; Sat, 18 Feb 2023 16:56:24 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1pTVBo-000613-BN; Sat, 18 Feb 2023 21:56:16 +0000 In-Reply-To: <20230218.061335.1468428093197134401.tats%nobody@tats.iris.ne.jp> (Tatsuya Kinoshita's message of "Sat, 18 Feb 2023 06:13:35 +0900 (JST)") Received-SPF: pass client-ip=205.166.94.33; envelope-from=akrl@sdf.org; helo=ma.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303535 Archived-At: Tatsuya Kinoshita writes: > On 2023-02-17 at 09:42 -0700, Sean Whitton wrote: >> So: commit ce4a066ed1e fixes Debian bug #1021842 without the env var. > > On 2023-02-14 at 11:32 +0000, Andrea Corallo wrote: >> Stefan Monnier writes: >> > `temporary-file-directory' may point to a world-writable directory, so >> > it's vulnerable to the usual race condition where someone manages to >> > predict the name of the file you're going to write and places there >> > a symlink to some "interesting" place, so you end up overwriting some >> > other file unwittingly. >> >> Okay, ce4a066ed1e generates trampolines in a temporary directory if no >> other option is viable (using the make-temp-file machinery to generate >> the unpredictable name). > >> + finally (cl-return >> + (expand-file-name >> + (make-temp-file-internal (file-name-sans-extension rel-filename) >> + 0 ".eln" nil) >> + temporary-file-directory)))) > > Hmm, it seems using make-temp-file-internal with DIR-FLAG=0 which just > constructs a name and do not create the file like make-temp-name, so > there is a race condition as Stefan mentioned. Is that really OK? Mmhh, Stefan mentioned the case where the tmp file name is predicted. Shouldn't make-temp-file-internal return a non predictable file name? Otherwise what's the point of using make-temp-file in the first place if the temporary name is predictable? Andrea