From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/native-comp c36b4ee 2/2: [TODO] Remove noisy anti-noise feature Date: Wed, 18 Nov 2020 17:37:19 +0000 Message-ID: References: <20201118142127.27797.43745@vcs0.savannah.gnu.org> <20201118142128.E137D20D1E@vcs0.savannah.gnu.org> <87r1oqlmoj.fsf@gmail.com> <87pn4abng6.fsf@bernoul.li> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13373"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Robert Pluim , emacs-devel@gnu.org To: Jonas Bernoulli Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 18 18:49:39 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfRaN-0003OC-5B for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 18:49:39 +0100 Original-Received: from localhost ([::1]:42296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfRaM-0003hu-7I for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Nov 2020 12:49:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfROd-0002Mr-NA for emacs-devel@gnu.org; Wed, 18 Nov 2020 12:37:32 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:52033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfROY-0004VE-LD for emacs-devel@gnu.org; Wed, 18 Nov 2020 12:37:30 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 0AIHbJPl020909; Wed, 18 Nov 2020 17:37:19 GMT In-Reply-To: <87pn4abng6.fsf@bernoul.li> (Jonas Bernoulli's message of "Wed, 18 Nov 2020 18:10:33 +0100") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 10:30:26 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259369 Archived-At: Jonas Bernoulli writes: > Robert Pluim writes: > >> jonas@bernoul.li (Jonas Bernoulli) writes: >> >>> branch: feature/native-comp >>> commit c36b4eed2d76f0e804d27d35dd6281f858639f94 >>> Author: Jonas Bernoulli >>> Commit: Jonas Bernoulli >>> >>> [TODO] Remove noisy anti-noise feature >>> --- >>> lisp/emacs-lisp/warnings.el | 11 ----------- >>> 1 file changed, 11 deletions(-) >>> >> >> Everyone is allowed to have an opinion on this feature, but just >> removing it without discussion seems a little harsh. >> >> Robert > > That was an accidental push. I do think it would be best to remove > this new feature completely, but of course I would have raised the > issue before *intentionally* removing it. Hi Jonas, thanks for the revert, please next time specify the reason of the revert in the commit, (as I've recently discovered) this is the conventional way to proceed :) Ciao Andrea