all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrea Corallo <akrl@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: acm@muc.de, emacs-devel@gnu.org
Subject: Re: How does one find out what file a library has been loaded from?
Date: Tue, 02 Aug 2022 08:43:53 +0000	[thread overview]
Message-ID: <xjfy1w7jara.fsf@ma.sdf.org> (raw)
In-Reply-To: <xjfczdkl3ly.fsf@ma.sdf.org> (Andrea Corallo's message of "Mon, 01 Aug 2022 09:23:05 +0000")

Andrea Corallo <akrl@sdf.org> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Andrea Corallo <akrl@sdf.org>
>>> Cc: acm@muc.de, emacs-devel@gnu.org
>>> Date: Sun, 24 Jul 2022 17:46:02 +0000
>>> 
>>> >> (native-comp-unit-file (subr-native-comp-unit (symbol-function #'find-file)))
>>> >
>>> > Andrea, does anything similar to subr-native-comp-unit exists for
>>> > other types of symbols accepted by symbol-file: defvar and defface?
>>> 
>>> No it does not exists.
>>> 
>>> The reason why the compilation unit concept was introduced is to have
>>> the GC capable of unloading the eln when possible, this mechanism is
>>> only related to functions that are indeed memory mapped from the loaded
>>> shared libraries.  Variables etc are just regular variables (tipically
>>> defined at eln load time) so they didn't required any new mechanism.
>>> 
>>> > If not, then the only way to produce the same information for them
>>> > would be to generate the base name of the .eln file with
>>> > comp-el-to-eln-rel-filename, and then look for that file along
>>> > native-comp-eln-load-path, right?
>>> 
>>> Yes I think so.
>>
>> Andrea and Alan, please review and test the version of symbol-file
>> below that I intend to install soon.  TIA.
>>
>> (defun locate-eln-file (eln-file)
>>   "Locate a natively-compiled ELN-FILE by searching its load path.
>> This function looks in directories named by `native-comp-eln-load-path'."
>>   (or (locate-file-internal (concat comp-native-version-dir "/" eln-file)
>> 		   native-comp-eln-load-path)
>>       (locate-file-internal
>>        ;; Preloaded *.eln files live in the preloaded/ subdirectory of
>>        ;; the last entry in `native-comp-eln-load-path'.
>>        (concat comp-native-version-dir "/preloaded/" eln-file)
>>        (last native-comp-eln-load-path))))
>>
>> (defun symbol-file (symbol &optional type native-p)
>>   "Return the name of the file that defined SYMBOL.
>> The value is normally an absolute file name.  It can also be nil,
>> if the definition is not associated with any file.  If SYMBOL
>> specifies an autoloaded function, the value can be a relative
>> file name without extension.
>>
>> If TYPE is nil, then any kind of definition is acceptable.  If
>> TYPE is `defun', `defvar', or `defface', that specifies function
>> definition, variable definition, or face definition only.
>> Otherwise TYPE is assumed to be a symbol property.
>>
>> If NATIVE-P is nil, and SYMBOL was loaded from a .eln file, this
>> function will return the absolute file name of that .eln file,
>> if found.
>>
>> This function only works for symbols defined in Lisp files.  For
>> symbols that are defined in C files, use `help-C-file-name'
>> instead."
>>   (if (and (or (null type) (eq type 'defun))
>> 	   (symbolp symbol)
>> 	   (autoloadp (symbol-function symbol)))
>>       (nth 1 (symbol-function symbol))
>>     (if (and native-p (or (null type) (eq type 'defun))
>> 	     (symbolp symbol)
>> 	     (subr-native-elisp-p (symbol-function symbol)))
>> 	;; native-comp-unit-file returns unnormalized file names.
>> 	(expand-file-name (native-comp-unit-file (subr-native-comp-unit
>> 						  (symbol-function symbol))))
>>       (let ((elc-file
>> 	     (catch 'found
>> 	       (pcase-dolist (`(,file . ,elems) load-history)
>> 		 (when (if type
>> 			   (if (eq type 'defvar)
>> 			       ;; Variables are present just as their
>> 			       ;; names.
>> 			       (member symbol elems)
>> 			     ;; Many other types are represented as
>> 			     ;; (TYPE . NAME).
>> 			     (or (member (cons type symbol) elems)
>> 				 (memq
>> 				  symbol
>> 				  (alist-get type
>> 					     (alist-get 'define-symbol-props
>> 							elems)))))
>> 			 ;; We accept all types, so look for variable def
>> 			 ;; and then for any other kind.
>> 			 (or (member symbol elems)
>> 			     (let ((match (rassq symbol elems)))
>> 			       (and match
>> 				    (not (eq 'require (car match)))))))
>> 		   (throw 'found file))))))
>> 	;; If they asked for the .eln file, try to find it.
>> 	(or (and elc-file
>> 		 native-p
>> 		 (let* ((sans-ext (file-name-sans-extension elc-file))
>> 			(el-file
>> 			 (and (fboundp 'zlib-available-p)
>> 			      (zlib-available-p)
>> 			      (concat sans-ext ".el.gz")))
>> 			(el-file-backup (concat sans-ext ".el")))
>> 		   (or (and el-file (file-exists-p el-file))
>> 		       (and (file-exists-p el-file-backup)
>> 			    (setq el-file el-file-backup))
>> 		       (setq el-file nil))
>> 		   (if (stringp el-file)
>> 		       (locate-eln-file
>> 			(comp-el-to-eln-rel-filename el-file)))))
>> 	    elc-file)))))
>
> Hi Eli,
>
> I think this has some overlap with the code we have in
> 'maybe_swap_for_eln', but it does not look trivial to decouple it, so
> I'm not sure is it worth the pain.
>
> Other than that only note I've is that (in 'maybe_swap_for_eln1') we do
> reject the .eln file if it's younger than the corresponding .elc one.  I
> think we should mimic this as well here no?

I do realize now this is probably not a real case as: if (in
'maybe_swap_for_eln1') we reject the eln while loading because older
than the elc we give up entirely on loading native code, even if might
be available in another directory down in `native-comp-eln-load-path'.
So your code should be just fine in this respect.

Thanks

  Andrea




  reply	other threads:[~2022-08-02  8:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 10:52 How does one find out what file a library has been loaded from? Alan Mackenzie
2022-07-19 12:39 ` Eli Zaretskii
2022-07-19 15:01   ` Alan Mackenzie
2022-07-19 15:32     ` Andrea Corallo
2022-07-24 16:07       ` Eli Zaretskii
2022-07-24 17:46         ` Andrea Corallo
2022-07-31 12:52           ` Eli Zaretskii
2022-08-01  9:23             ` Andrea Corallo
2022-08-02  8:43               ` Andrea Corallo [this message]
2022-08-02 12:12                 ` Eli Zaretskii
2022-08-02 14:13                   ` Andrea Corallo
2022-08-03 14:19                     ` Eli Zaretskii
2022-08-01 19:31             ` Alan Mackenzie
2022-08-03 14:16               ` Eli Zaretskii
2022-07-19 15:50     ` Eli Zaretskii
2022-07-19 17:07       ` Alan Mackenzie
2022-07-19 19:13         ` Eli Zaretskii
2022-07-20 11:47           ` Alan Mackenzie
2022-07-20 15:31             ` Stefan Monnier
2022-07-20 20:34             ` Alan Mackenzie
2022-07-21  6:13               ` Eli Zaretskii
2022-07-21 17:37                 ` Alan Mackenzie
2022-07-21 17:52                   ` Stefan Monnier
2022-07-21 18:24                     ` Alan Mackenzie
2022-07-21 18:37                       ` Stefan Monnier
2022-07-21 21:03                         ` Alan Mackenzie
2022-07-21 23:15                           ` Stefan Monnier
2022-07-21 17:53                   ` Eli Zaretskii
2022-07-21 20:39                     ` Alan Mackenzie
2022-07-23 10:11                       ` Eli Zaretskii
2022-07-24 11:27                         ` Alan Mackenzie
2022-07-24 12:16                           ` Eli Zaretskii
2022-07-24 15:37                             ` Eli Zaretskii
2022-07-24 15:42                               ` Eli Zaretskii
2022-07-24 15:32                           ` Stefan Monnier
2022-07-24 15:49                             ` T.V Raman
2022-07-24 16:11                               ` Stefan Monnier
2022-07-24 18:21                                 ` T.V Raman
2022-07-24 18:50                                   ` Stefan Monnier
2022-07-24 16:19                               ` Eli Zaretskii
2022-07-19 16:27     ` Stefan Monnier
2022-07-20 18:36       ` Andrea Corallo
2022-07-21  7:20         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfy1w7jara.fsf@ma.sdf.org \
    --to=akrl@sdf.org \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.