From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Date: Tue, 09 Mar 2021 08:32:46 +0000 Message-ID: References: <83h7m84h9g.fsf@gnu.org> <86v9ao5czu.fsf@gmail.com> <86wnutogrh.fsf@gmail.com> <86wnut8fb9.fsf@gmail.com> <861rd1tbpa.fsf@gmail.com> <83pn0km6y3.fsf@gnu.org> <86ft1f8ara.fsf@gmail.com> <83sg5cjdn8.fsf@gnu.org> <83r1kwjcy2.fsf@gnu.org> <8335x6u9o4.fsf@gnu.org> <83zgzesrku.fsf@gnu.org> <83tupms4mp.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7067"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , andrewjmoreton@gmail.com, 46256@debbugs.gnu.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 09 09:33:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lJXnl-0001k1-6f for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 09:33:13 +0100 Original-Received: from localhost ([::1]:59098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJXnk-0001r6-5p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Mar 2021 03:33:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJXna-0001r0-PF for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 03:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJXna-0004Vm-I8 for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 03:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lJXna-0001Gw-Bq for bug-gnu-emacs@gnu.org; Tue, 09 Mar 2021 03:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Mar 2021 08:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46256 X-GNU-PR-Package: emacs Original-Received: via spool by 46256-submit@debbugs.gnu.org id=B46256.16152787694867 (code B ref 46256); Tue, 09 Mar 2021 08:33:02 +0000 Original-Received: (at 46256) by debbugs.gnu.org; 9 Mar 2021 08:32:49 +0000 Original-Received: from localhost ([127.0.0.1]:45557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJXnM-0001GQ-Rp for submit@debbugs.gnu.org; Tue, 09 Mar 2021 03:32:49 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:51055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lJXnL-0001GJ-Km for 46256@debbugs.gnu.org; Tue, 09 Mar 2021 03:32:48 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 1298Wkgt026620 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 9 Mar 2021 08:32:47 GMT In-Reply-To: (Pip Cet's message of "Mon, 8 Mar 2021 06:48:40 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201902 Archived-At: Pip Cet writes: > On Mon, Mar 8, 2021 at 5:54 AM Pip Cet wrote: >> Note that this might not always work because of conservative GC. > > If it doesn't work, can you simply retry a few times? Eventually there > shouldn't be references to the stale native_comp_unit on the stack. > > However, I think I've worked out why dynlib_close doesn't do its job: > > Fnative_elisp_load creates a comp unit, but, if the shared library has > already been initialized, it doesn't set that comp unit's comp_unit > variable to point to the new comp unit; instead, it will continue > pointing to the first comp unit which still has it open. > > Then, the original comp unit is unloaded but not the new one created > by Fnative_elisp_load. We call dynlib_close() once, but we called it > twice before, leaving the shared library open and initialized. > > Then, we try to load the comp unit again, and follow the stale > comp_unit variable pointing to the original comp unit. > > Fix should be as attached. Note the fix is, at worst, harmless (unless > I messed up), so we should apply it anyway just because it's good not > to leave stale pointers lying around even if we hope that the OS > unmaps them at some point. > > Pip The original code was written in the assumption that dlclose (as FreeLibrary) can't fail unloading a shared when the internal refcount goes to zero. As this is not the case I think the suggested patch is the correct fix. I've installed it as 93f92cf1ba. Thanks! Andrea