From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: akrl--- via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: [feature/native-comp] breakage on build Date: Sat, 30 Jan 2021 20:17:58 +0000 Message-ID: References: <87lfca7lsb.fsf@russet.org.uk> <463a837ca8ddbf7533c403350d75125d@russet.org.uk> <39105f71034e0902a749994dda9c4704@russet.org.uk> <83mtwq8kf3.fsf@gnu.org> <83k0ru8jnx.fsf@gnu.org> <83im7e8icf.fsf@gnu.org> <838s8a8adr.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31279"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, phillip.lord@russet.org.uk To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 30 21:18:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5whr-000837-Sf for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jan 2021 21:18:55 +0100 Original-Received: from localhost ([::1]:37458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5whq-0002jX-Uy for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jan 2021 15:18:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5wh2-0002Fu-CM for emacs-devel@gnu.org; Sat, 30 Jan 2021 15:18:05 -0500 Original-Received: from mab.sdf.org ([205.166.94.33]:38570 helo=ma.sdf.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5wgz-0005iW-Mv; Sat, 30 Jan 2021 15:18:04 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1l5wgw-0006LQ-AN; Sat, 30 Jan 2021 20:17:58 +0000 In-Reply-To: <838s8a8adr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Jan 2021 21:58:40 +0200") Received-SPF: pass client-ip=205.166.94.33; envelope-from=akrl@sdf.org; helo=ma.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263637 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: phillip.lord@russet.org.uk, emacs-devel@gnu.org >> Date: Sat, 30 Jan 2021 19:44:56 +0000 >> >> native-lisp/28.0.50-x86_64-w64-mingw32-HASH1/titdic-cnv-HASH2-HASH3.eln >> >> - HASH1 disambiguate triplet, Emacs configuration, version etc. > > But that information is already present in the text before: > 28.0.50-x86_64-w64-mingw32. What else is missing that we need a hash? I left the text before as indicative and human readable but unfortunatelly that's not complete. The list of all primitive functions contribute to the eln linking mechanism we use and is accounted in this hash. Also we can trigger the generation of a new hash each time we deploy an eln ABI breaking change. >> The lenght of these hashes is coming directly from the algo we use >> (md5), I think collision is really not an issue so we can easlily short >> these. > > Then I think we should indeed short them, because this issue will bite > us again. That's easy, we should just pick a lenght we like. Thanks Andrea