From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Update 1 on Bytecode Offset tracking Date: Thu, 16 Jul 2020 07:25:45 +0000 Message-ID: References: <87a700fk3j.fsf@gmail.com> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12427"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: emacs-devel@gnu.org, Rocky Bernstein To: Zach Shaftel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 16 09:26:22 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jvyHe-000374-85 for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Jul 2020 09:26:22 +0200 Original-Received: from localhost ([::1]:32866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jvyHd-0001ut-AW for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Jul 2020 03:26:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvyHA-0001VL-UY for emacs-devel@gnu.org; Thu, 16 Jul 2020 03:25:52 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:63563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvyH8-0006qY-Hu; Thu, 16 Jul 2020 03:25:52 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 06G7PjYc025991; Thu, 16 Jul 2020 07:25:45 GMT In-Reply-To: <87a700fk3j.fsf@gmail.com> (Zach Shaftel's message of "Wed, 15 Jul 2020 19:10:32 -0400") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 03:25:46 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252979 Archived-At: Hi Zach and Rocky, IMO having the exact offset for all functions in the stack except the last is already a measurable improvement. Reevaluating the top function and rerunning is not a huge deal, reevaluating N functions and rerunning each time trying to figure out what is going wrong and where on the contrary can be considerably more painful. Zach Shaftel writes: > With respect to reporting offsets, using code from edebug we have a > Lisp-Expression reader that will track source-code locations and > store the information in a source-map-expression cl-struct. The code > in progress is here. > > Information currently saved is: > > The expression itself > The exact string that was read > Begin and end point=E2=80=8Bs of the sexp in the buffer > source-map-expression children (for conses and vectors) > > which can be generated for a whole lisp file with the function > source-map-file. We are testing this on lots of files such as the > lisp files in the GNU Emacs distribution. After this is done we will > try hooking this into the compilation process. Regarding the reader I fear modifying the C one will be the only way if we want to have something sufficiently high performance to be used as default. That said having one to begin with experimenting is a very good start. I guess we'll want to have the 'children' as key of an hash where the rest is the value. Thanks you and Rocky for the effort! Andrea --=20 akrl@sdf.org