From: Andrea Corallo via "Emacs development discussions." <emacs-devel@gnu.org>
To: Zach Shaftel <zshaftel@gmail.com>
Cc: emacs-devel@gnu.org, Rocky Bernstein <rocky@gnu.org>
Subject: Re: Update 1 on Bytecode Offset tracking
Date: Thu, 16 Jul 2020 07:25:45 +0000 [thread overview]
Message-ID: <xjfsgdrgbuu.fsf@sdf.org> (raw)
In-Reply-To: <87a700fk3j.fsf@gmail.com> (Zach Shaftel's message of "Wed, 15 Jul 2020 19:10:32 -0400")
Hi Zach and Rocky,
IMO having the exact offset for all functions in the stack except the
last is already a measurable improvement. Reevaluating the top function
and rerunning is not a huge deal, reevaluating N functions and rerunning
each time trying to figure out what is going wrong and where on the
contrary can be considerably more painful.
Zach Shaftel <zshaftel@gmail.com> writes:
> With respect to reporting offsets, using code from edebug we have a
> Lisp-Expression reader that will track source-code locations and
> store the information in a source-map-expression cl-struct. The code
> in progress is here.
>
> Information currently saved is:
>
> The expression itself
> The exact string that was read
> Begin and end points of the sexp in the buffer
> source-map-expression children (for conses and vectors)
>
> which can be generated for a whole lisp file with the function
> source-map-file. We are testing this on lots of files such as the
> lisp files in the GNU Emacs distribution. After this is done we will
> try hooking this into the compilation process.
Regarding the reader I fear modifying the C one will be the only way if
we want to have something sufficiently high performance to be used as
default. That said having one to begin with experimenting is a very
good start. I guess we'll want to have the 'children' as key of an hash
where the rest is the value.
Thanks you and Rocky for the effort!
Andrea
--
akrl@sdf.org
next prev parent reply other threads:[~2020-07-16 7:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 23:10 Update 1 on Bytecode Offset tracking Zach Shaftel
2020-07-16 3:55 ` Stefan Monnier
2020-07-16 22:45 ` Zach Shaftel
2020-07-17 3:44 ` Eli Zaretskii
2020-07-17 16:20 ` Stefan Monnier
2020-07-17 20:19 ` Zach Shaftel
2020-07-17 22:08 ` Stefan Monnier
2020-07-18 21:41 ` Zach Shaftel
2020-07-19 2:34 ` Stefan Monnier
2020-07-21 0:28 ` Zach Shaftel
2020-07-21 2:51 ` Stefan Monnier
2020-07-16 7:25 ` Andrea Corallo via Emacs development discussions. [this message]
2020-07-17 0:24 ` Zach Shaftel
2020-07-17 13:47 ` Rocky Bernstein
2020-07-28 19:19 ` Update 2 " Zach Shaftel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfsgdrgbuu.fsf@sdf.org \
--to=emacs-devel@gnu.org \
--cc=akrl@sdf.org \
--cc=rocky@gnu.org \
--cc=zshaftel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.