bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Tom Gillespie]

Hi Andrea,
    On feature/native-comp at 8a931a97b8dd19a38d6f719f810280a07ba76438
I am unable to use xref-find-definition to resolve a large subset of functions
including shell-command. This was not an issue at
9f01ce6327af886f26399924a9aadf16cdd4fd9f and is not an issue on master at
a566e409d0d962d3c2870691175836da22c31111. Repro is below and the messages
point to the cause being that xref-find-definitions is now looking in
the location where
the el files were during compilation instead of where they have been
installed. This
will cause problems for anyone distributing emacs in addition to distros where
compilation is sandboxed. To reproduce it on your end I suspect that
you will need
to use a different compile and install location for the el files. Best!
Tom

Repro:
emacs -q -batch --no-site-file --eval "(xref-find-definitions 'shell-command)"
Stdout:
No library /var/tmp/portage/app-editors/emacs-28.0.9999-r1/work/emacs/lisp/simple.el
in search path
No definitions found for: shell-command

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Tom Gillespie <tgbugs@gmail.com> writes:

> Hi Andrea,
>     On feature/native-comp at 8a931a97b8dd19a38d6f719f810280a07ba76438
> I am unable to use xref-find-definition to resolve a large subset of functions
> including shell-command. This was not an issue at
> 9f01ce6327af886f26399924a9aadf16cdd4fd9f and is not an issue on master at
> a566e409d0d962d3c2870691175836da22c31111. Repro is below and the messages
> point to the cause being that xref-find-definitions is now looking in
> the location where
> the el files were during compilation instead of where they have been
> installed. This
> will cause problems for anyone distributing emacs in addition to distros where
> compilation is sandboxed. To reproduce it on your end I suspect that
> you will need
> to use a different compile and install location for the el files. Best!
> Tom

Hi Tom,

I believe could be an issue related to commit I've just reverted, could
you give a try to the last state?

If you still see it could you open a bug in the emacs bug tracker about
that?  I've a number of things in the queue and that's the best place to
cumulate and discuss these.

Thanks!

  Andrea

-- 
akrl@sdf.org

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> If you still see it could you open a bug in the emacs bug tracker about
> that?  I've a number of things in the queue and that's the best place to
> cumulate and discuss these.

Oops missed that, it is already! thanks :)

-- 
akrl@sdf.org

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Tom Gillespie]

This is fixed at c818c29771d3cb51875643b2f6c894073e429dd2 for me so it
looks like that reversion did the trick. Thanks!

On Thu, Aug 20, 2020 at 4:10 AM Andrea Corallo <akrl@sdf.org> wrote:
>
> Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
> > If you still see it could you open a bug in the emacs bug tracker about
> > that?  I've a number of things in the queue and that's the best place to
> > cumulate and discuss these.
>
> Oops missed that, it is already! thanks :)
>
> --
> akrl@sdf.org

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Tom Gillespie <tgbugs@gmail.com> writes:

> This is fixed at c818c29771d3cb51875643b2f6c894073e429dd2 for me so it
> looks like that reversion did the trick. Thanks!

Thank you for reporting that!  Closing

  Andrea

-- 
akrl@sdf.org

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Tom Gillespie]

It seems that the problem was only partially fixed at
c818c29771d3cb51875643b2f6c894073e429dd2.

emacs -q -batch --no-site-file --eval "(xref-find-definitions
'shell-command)" succeeds whereas

emacs -q -batch --no-site-file --eval "(xref-find-definitions 'looking-at-p)"
No library /var/tmp/portage/app-editors/emacs-28.0.9999-r1/work/emacs/lisp/subr.el
in search path
No definitions found for: looking-at-p

A wrinkle is that the following succeeds when I explicitly require
'subr, but produces another warning which seems like it
might be related to why 'looking-at-p is not found without explicitly
requiring 'subr.
emacs -q -batch --no-site-file --eval "(require 'subr)" --eval
"(xref-find-definitions 'looking-at-p)"
Loading file /usr/libexec/emacs/28.0.50/x86_64-pc-linux-gnu/eln-cache/x86_64-pc-linux-gnu-bbae9d63d1309894/subr-8e7058db29bf20a68ef89651c940f16d2e5087b6bf685b48ddeb1de1dcd6ad02.eln
failed to provide feature ‘subr’

On Fri, Aug 21, 2020 at 12:44 AM Andrea Corallo <akrl@sdf.org> wrote:
>
> Tom Gillespie <tgbugs@gmail.com> writes:
>
> > This is fixed at c818c29771d3cb51875643b2f6c894073e429dd2 for me so it
> > looks like that reversion did the trick. Thanks!
>
> Thank you for reporting that!  Closing
>
>   Andrea
>
> --
> akrl@sdf.org

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Tom Gillespie]

Here is another test case.

emacs -q -batch --no-site-file --eval "(xref-find-definitions 'defun)"
No library /var/tmp/portage/app-editors/emacs-28.0.9999-r1/work/emacs/lisp/emacs-lisp/byte-run.el
in search path
No definitions found for: defun

emacs -q -batch --no-site-file --eval "(require 'byte-run)" --eval
"(xref-find-definitions 'defun)"
Loading file /usr/libexec/emacs/28.0.50/x86_64-pc-linux-gnu/eln-cache/x86_64-pc-linux-gnu-bbae9d63d1309894/byte-run-1e5facaeb87321037982c815be905e28eaf4253c367238bb2eff9b4286620542.eln
failed to provide feature ‘byte-run’

On Sat, Aug 22, 2020 at 2:53 PM Tom Gillespie <tgbugs@gmail.com> wrote:
>
> It seems that the problem was only partially fixed at
> c818c29771d3cb51875643b2f6c894073e429dd2.
>
> emacs -q -batch --no-site-file --eval "(xref-find-definitions
> 'shell-command)" succeeds whereas
>
> emacs -q -batch --no-site-file --eval "(xref-find-definitions 'looking-at-p)"
> No library /var/tmp/portage/app-editors/emacs-28.0.9999-r1/work/emacs/lisp/subr.el
> in search path
> No definitions found for: looking-at-p
>
> A wrinkle is that the following succeeds when I explicitly require
> 'subr, but produces another warning which seems like it
> might be related to why 'looking-at-p is not found without explicitly
> requiring 'subr.
> emacs -q -batch --no-site-file --eval "(require 'subr)" --eval
> "(xref-find-definitions 'looking-at-p)"
> Loading file /usr/libexec/emacs/28.0.50/x86_64-pc-linux-gnu/eln-cache/x86_64-pc-linux-gnu-bbae9d63d1309894/subr-8e7058db29bf20a68ef89651c940f16d2e5087b6bf685b48ddeb1de1dcd6ad02.eln
> failed to provide feature ‘subr’
>
> On Fri, Aug 21, 2020 at 12:44 AM Andrea Corallo <akrl@sdf.org> wrote:
> >
> > Tom Gillespie <tgbugs@gmail.com> writes:
> >
> > > This is fixed at c818c29771d3cb51875643b2f6c894073e429dd2 for me so it
> > > looks like that reversion did the trick. Thanks!
> >
> > Thank you for reporting that!  Closing
> >
> >   Andrea
> >
> > --
> > akrl@sdf.org

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Tom Gillespie <tgbugs@gmail.com> writes:

> Here is another test case.
>
> emacs -q -batch --no-site-file --eval "(xref-find-definitions 'defun)"
> No library /var/tmp/portage/app-editors/emacs-28.0.9999-r1/work/emacs/lisp/emacs-lisp/byte-run.el
> in search path
> No definitions found for: defun

Hi Tom,

I think this should be fixed by the today's fixes.

Could have a look to confirm?

Thanks!

  Andrea

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Tom Gillespie]

Hi Andrea,
   Confirming that all the examples from this thread are working for
me at ea35a62e6e200f00e22828a7d0994ee2a4d2fc6a. Thanks!
Tom

On Sat, Aug 29, 2020 at 11:21 AM Andrea Corallo <akrl@sdf.org> wrote:
>
> Tom Gillespie <tgbugs@gmail.com> writes:
>
> > Here is another test case.
> >
> > emacs -q -batch --no-site-file --eval "(xref-find-definitions 'defun)"
> > No library /var/tmp/portage/app-editors/emacs-28.0.9999-r1/work/emacs/lisp/emacs-lisp/byte-run.el
> > in search path
> > No definitions found for: defun
>
> Hi Tom,
>
> I think this should be fixed by the today's fixes.
>
> Could have a look to confirm?
>
> Thanks!
>
>   Andrea

bug#42940: feature/native-comp; xref-find-definition searches compile location of el files instead of install location

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Tom Gillespie <tgbugs@gmail.com> writes:

> Hi Andrea,
>    Confirming that all the examples from this thread are working for
> me at ea35a62e6e200f00e22828a7d0994ee2a4d2fc6a. Thanks!
> Tom

Very nice, closing.

Thanks!

  Andrea