From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#52773: Master and (probably) emacs-28: locate-library hides .eln files. Date: Fri, 24 Dec 2021 13:18:13 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5681"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 52773@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 24 14:19:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n0kTe-0001HW-Ng for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Dec 2021 14:19:18 +0100 Original-Received: from localhost ([::1]:35996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0kTd-0007qU-Dy for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Dec 2021 08:19:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0kTO-0007qL-L8 for bug-gnu-emacs@gnu.org; Fri, 24 Dec 2021 08:19:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0kTO-0003ic-64 for bug-gnu-emacs@gnu.org; Fri, 24 Dec 2021 08:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n0kTN-00029B-Ou for bug-gnu-emacs@gnu.org; Fri, 24 Dec 2021 08:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Dec 2021 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52773 X-GNU-PR-Package: emacs Original-Received: via spool by 52773-submit@debbugs.gnu.org id=B52773.16403519008196 (code B ref 52773); Fri, 24 Dec 2021 13:19:01 +0000 Original-Received: (at 52773) by debbugs.gnu.org; 24 Dec 2021 13:18:20 +0000 Original-Received: from localhost ([127.0.0.1]:35863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kSh-000287-Vp for submit@debbugs.gnu.org; Fri, 24 Dec 2021 08:18:20 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:55835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n0kSd-00027x-An for 52773@debbugs.gnu.org; Fri, 24 Dec 2021 08:18:18 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 1BODIDNl015502 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 24 Dec 2021 13:18:14 GMT In-Reply-To: (Alan Mackenzie's message of "Fri, 24 Dec 2021 11:22:48 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223046 Archived-At: Alan Mackenzie writes: > Hello, Emacs and Andrea. > > With a native compiled recent master branch, do: > > emacs -Q > M-x locate-library files > > The result in the echo area is something like: > > > Library is file ~/emacs/emacs.git/sub-master-5/lisp/files.el > ^^^ > > .. This is wrong. The Emacs is _NOT_ running uncompiled Lisp, it's > running native compiled files. The reply should be a file name ending > in ".eln". > > This problem is surely also in the emacs-28 branch. > > ######################################################################### > > The cause of the problem is in `locate-file' in files.el. There, if a > ..eln file is found, it's corresponding .el source is looked up in a hash > table, and the .el name returned instead. > > This mechanism was inserted by the following patch: > > commit 3224a443060a5f21bb910064fc06fe4432810355 > Author: Andrea Corallo > Date: Sun Jul 19 10:46:24 2020 +0200 > > Move eln files into dedicated cache directories > > When loading a elc file search for a corresponding eln one into > `comp-eln-load-path' directories and load it if available. > `comp-eln-load-path' contains by default two directory (user and > system one). > > It seems there is some use case for which returning the .el file name in > place of the .eln is appropriate. It isn't appropriate for > locate-library. > > I would suggest moving the hash table mechanism out of locate-file, and > into the other function which calls locate-file, where the substitution > is wanted. [resending as the mail was rejected by bug-gnu-emacs@debbugs.gnu.org] Hi Alan, The trouble in this area is that `locate-library' might be used by existing programs to obtain the source file (.elc files are tipically in the same directory where the corresponding .el are). This was the big trouble also for `load-file-name' and that's why we had to add `load-true-file-name', all other solution caused unacceptable incompatibilities with existing software. AFAIR `locate-library' had the same exact issue. Best Regards Andrea